ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "headius (Charles Nutter) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "headius (Charles Nutter)" <noreply@ruby-lang.org>
Subject: [ruby-core:121225] [Ruby master Bug#21162] Regexp casefold mismatch for latin1 supplemental chars
Date: Mon, 03 Mar 2025 18:05:07 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-112167.20250303180506.286@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-21162.20250227213353.286@ruby-lang.org>

Issue #21162 has been updated by headius (Charles Nutter).


@nobu Certainly could be and the fix looks similar.

@mjrzasa What do you think? Does your fix repair this problem?

----------------------------------------
Bug #21162: Regexp casefold mismatch for latin1 supplemental chars
https://bugs.ruby-lang.org/issues/21162#change-112167

* Author: headius (Charles Nutter)
* Status: Open
* Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
Originally reported to joni repo with a possible fix here: https://github.com/jruby/joni/pull/20

>From that PR:

> When a character is less than or equal to single byte size (0xff),
> yet it takes more than 1 byte in the current encoding, the
> case folding code incorrectly put it in bitset instead of code
> range. As a result, for utf8 encoding, casefold works incorrectly
> on characters in range \u0080 to \u00ff (latin1 supplement).
> 
> Before fix:
> 
> "\u00c2" [\u00e0-\u00e5] returns false
> "\u00c2" [\u00e2] returns false
> "\u00c2" \u00e2 returns true

As a Ruby example:

```
$ ruby -v -e 'p(/[\u00e0-\u00e5]/i =~ "\u00c2")'
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [arm64-darwin24]
nil
```

The PR above was rebased in https://github.com/jruby/joni/pull/85. When that patch is incorporated into JRuby, it behaves as expected:

```
$ ruby -v -e 'p(/[\u00e0-\u00e5]/i =~ "\u00c2")'
jruby 10.0.0.0-SNAPSHOT (3.4.0) 2025-02-27 c0e5008419 OpenJDK 64-Bit Server VM 21.0.5+11-LTS on 21.0.5+11-LTS +indy +jit [arm64-darwin]
0
```

This bug may affect other casefold situations. As I am not very familiar with this code in CRuby (other than from maintaining the port in joni) I would like others to evaluate this fix and help find other places it is needed.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

  parent reply	other threads:[~2025-03-03 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 21:33 [ruby-core:121201] " headius (Charles Nutter) via ruby-core
2025-02-28  7:14 ` [ruby-core:121204] " nobu (Nobuyoshi Nakada) via ruby-core
2025-03-03 18:05 ` headius (Charles Nutter) via ruby-core [this message]
2025-03-07 10:19 ` [ruby-core:121255] " nobu (Nobuyoshi Nakada) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-112167.20250303180506.286@ruby-lang.org \
    --to=ruby-core@ml.ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).