[ruby-core:122042] [Ruby Bug#21330] Namespace: Class and Module frozen status is not namespace

[ruby-core:122042] [Ruby Bug#21330] Namespace: Class and Module frozen status is not namespace

[byroot (Jean Boussier) via ruby-core]

Issue #21330 has been reported by byroot (Jean Boussier).

----------------------------------------
Bug #21330: Namespace: Class and Module frozen status is not namespace 
https://bugs.ruby-lang.org/issues/21330

* Author: byroot (Jean Boussier)
* Status: Open
* Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
```ruby
File.write("/tmp/test.rb", <<~'RUBY')
  Hash.freeze
RUBY

ns = Namespace.new
ns.require("/tmp/test.rb")

class Hash
  def monkey_patch
  end
end
```

Expected behavior:

Since the monkey patch is in a different namespace, I'd expect it to not impact code that is running in another namespace.

Actual behavior:

```
test.rb:9:in '<class:Hash>': can't modify frozen class: Hash (FrozenError)
```

The class is frozen globally, breaking code in other namespaces.

Is this by design, or does that mean the frozen status need to be moved in the `classext_t` as well?

cc @tagomoris 



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:122051] [Ruby Bug#21330] Namespace: Class and Module frozen status is not namespaced

[tagomoris (Satoshi Tagomori) via ruby-core]

Issue #21330 has been updated by tagomoris (Satoshi Tagomori).


The frozen flag is what I missed. I think we should move the flag to `rb_classext_t`.

----------------------------------------
Bug #21330: Namespace: Class and Module frozen status is not namespaced
https://bugs.ruby-lang.org/issues/21330#change-113201

* Author: byroot (Jean Boussier)
* Status: Open
* Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
```ruby
File.write("/tmp/test.rb", <<~'RUBY')
  Hash.freeze
RUBY

ns = Namespace.new
ns.require("/tmp/test.rb")

class Hash
  def monkey_patch
  end
end
```

Expected behavior:

Since the monkey patch is in a different namespace, I'd expect it to not impact code that is running in another namespace.

Actual behavior:

```
test.rb:9:in '<class:Hash>': can't modify frozen class: Hash (FrozenError)
```

The class is frozen globally, breaking code in other namespaces.

Is this by design, or does that mean the frozen status need to be moved in the `classext_t` as well?

cc @tagomoris 



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:122386] [Ruby Bug#21330] Namespace: Class and Module frozen status is not namespaced

[ko1 (Koichi Sasada) via ruby-core]

Issue #21330 has been updated by ko1 (Koichi Sasada).


I'm afraid that moving frozen flag into class_ext (and each built-in class variants can has each frozen state) makese `OBJ_FROZEN` code:


```C
// include/ruby/internal/fl_type.h
static inline VALUE
RB_OBJ_FROZEN_RAW(VALUE obj)
{
    return RB_FL_TEST_RAW(obj, RUBY_FL_FREEZE);
}
```

especially, if nobody freeze builtin classes. Any usecases?


----------------------------------------
Bug #21330: Namespace: Class and Module frozen status is not namespaced
https://bugs.ruby-lang.org/issues/21330#change-113550

* Author: byroot (Jean Boussier)
* Status: Open
* Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
```ruby
File.write("/tmp/test.rb", <<~'RUBY')
  Hash.freeze
RUBY

ns = Namespace.new
ns.require("/tmp/test.rb")

class Hash
  def monkey_patch
  end
end
```

Expected behavior:

Since the monkey patch is in a different namespace, I'd expect it to not impact code that is running in another namespace.

Actual behavior:

```
test.rb:9:in '<class:Hash>': can't modify frozen class: Hash (FrozenError)
```

The class is frozen globally, breaking code in other namespaces.

Is this by design, or does that mean the frozen status need to be moved in the `classext_t` as well?

cc @tagomoris 



-- 
https://bugs.ruby-lang.org/
______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:122387] [Ruby Bug#21330] Namespace: Class and Module frozen status is not namespaced

[jeremyevans0 (Jeremy Evans) via ruby-core]

Issue #21330 has been updated by jeremyevans0 (Jeremy Evans).


ko1 (Koichi Sasada) wrote in #note-4:
> I'm afraid that moving frozen flag into class_ext (and each built-in class variants can has each frozen state) makese `OBJ_FROZEN` code:
> 
> 
> ```C
> // include/ruby/internal/fl_type.h
> static inline VALUE
> RB_OBJ_FROZEN_RAW(VALUE obj)
> {
>     return RB_FL_TEST_RAW(obj, RUBY_FL_FREEZE);
> }
> ```
> 
> especially, if nobody freeze builtin classes. Any usecases?

roda-sequel-stack (https://github.com/jeremyevans/roda-sequel-stack) supports and recommends freezing all core classes at runtime (after the application is loaded).  This is how production Roda applications are commonly run.  Freezing core classes is recommended to ensure that no libraries the application is using are modifying the core classes at runtime (they probably aren't, but how can you be sure without freezing them)?

----------------------------------------
Bug #21330: Namespace: Class and Module frozen status is not namespaced
https://bugs.ruby-lang.org/issues/21330#change-113551

* Author: byroot (Jean Boussier)
* Status: Open
* Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
```ruby
File.write("/tmp/test.rb", <<~'RUBY')
  Hash.freeze
RUBY

ns = Namespace.new
ns.require("/tmp/test.rb")

class Hash
  def monkey_patch
  end
end
```

Expected behavior:

Since the monkey patch is in a different namespace, I'd expect it to not impact code that is running in another namespace.

Actual behavior:

```
test.rb:9:in '<class:Hash>': can't modify frozen class: Hash (FrozenError)
```

The class is frozen globally, breaking code in other namespaces.

Is this by design, or does that mean the frozen status need to be moved in the `classext_t` as well?

cc @tagomoris 



-- 
https://bugs.ruby-lang.org/
______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:122388] [Ruby Bug#21330] Namespace: Class and Module frozen status is not namespaced

[byroot (Jean Boussier) via ruby-core]

Issue #21330 has been updated by byroot (Jean Boussier).


> I'm afraid that moving frozen flag into class_ext (and each built-in class variants can has each frozen state) makese OBJ_FROZEN code:

It seems like your sentence is missing a word. Did you mean to say that it will make `OBJ_FROZEN` slower? If so yes, absolutely, but I thought it was a given. Namespaces are introducing a level of indirection it need to be checked and isn't cheap.

But on this note I'm currently working on two patches that may help with that:

  - Moving the frozen bit inside the shape_id: https://github.com/ruby/ruby/pull/13289
  - Delegating classes variables handling: https://github.com/ruby/ruby/pull/13411

With those two changes, once finished, I believe I can come up with a `RB_OBJ_FROZEN_RAW` that has almost the exact same performance.

> Any usecases?

What Jeremy said, but also just consistency? It's very hard to reason about a feature that isn't behaving consistently.



----------------------------------------
Bug #21330: Namespace: Class and Module frozen status is not namespaced
https://bugs.ruby-lang.org/issues/21330#change-113553

* Author: byroot (Jean Boussier)
* Status: Open
* Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN
----------------------------------------
```ruby
File.write("/tmp/test.rb", <<~'RUBY')
  Hash.freeze
RUBY

ns = Namespace.new
ns.require("/tmp/test.rb")

class Hash
  def monkey_patch
  end
end
```

Expected behavior:

Since the monkey patch is in a different namespace, I'd expect it to not impact code that is running in another namespace.

Actual behavior:

```
test.rb:9:in '<class:Hash>': can't modify frozen class: Hash (FrozenError)
```

The class is frozen globally, breaking code in other namespaces.

Is this by design, or does that mean the frozen status need to be moved in the `classext_t` as well?

cc @tagomoris 



-- 
https://bugs.ruby-lang.org/
______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/