[ruby-core:124604] [Ruby Bug#21847] Backport `syntax_suggest` 2.0.3 to supported branches

[ruby-core:124604] [Ruby Bug#21847] Backport `syntax_suggest` 2.0.3 to supported branches

[Earlopain (Earlopain _) via ruby-core]

Issue #21847 has been reported by Earlopain (Earlopain _).

----------------------------------------
Bug #21847: Backport `syntax_suggest` 2.0.3 to supported branches
https://bugs.ruby-lang.org/issues/21847

* Author: Earlopain (Earlopain _)
* Status: Open
* Backport: 3.2: DONTNEED, 3.3: REQUIRED, 3.4: REQUIRED, 4.0: REQUIRED
----------------------------------------
Prism contains a translation layer for ripper, which until very recently didn't emit `on_sp` tokens. This has now been implemented to improve compatibility.

However right after merging some `syntax_suggest` tests started failing: https://gist.github.com/schneems/834c75345b2085bda54dab69d913bcc0. `syntax_suggest` is using the ripper translation layer and is working around the missing `on_sp` tokens. Now that they are correctly created by prism, `syntax_suggest` is not able to handle these.

For prism this is just a bugfix but I do not want to break `syntax_suggest` unnecessarily. I asked @schneems and this is what he had to say about it: https://github.com/ruby/syntax_suggest/pull/243#issuecomment-3779113958

Backport PRs:




-- 
https://bugs.ruby-lang.org/
______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/

[ruby-core:124748] [Ruby Bug#21847] Backport `syntax_suggest` 2.0.3 to supported branches

[k0kubun (Takashi Kokubun) via ruby-core]

Issue #21847 has been updated by k0kubun (Takashi Kokubun).

Backport changed from 3.2: DONTNEED, 3.3: REQUIRED, 3.4: REQUIRED, 4.0: REQUIRED to 3.2: DONTNEED, 3.3: REQUIRED, 3.4: REQUIRED, 4.0: DONE

ruby_4_0 commit:e4dd078a2734f1f3b7169feb4da8c68587effc6e.

----------------------------------------
Bug #21847: Backport `syntax_suggest` 2.0.3 to supported branches
https://bugs.ruby-lang.org/issues/21847#change-116350

* Author: Earlopain (Earlopain _)
* Status: Closed
* Backport: 3.2: DONTNEED, 3.3: REQUIRED, 3.4: REQUIRED, 4.0: DONE
----------------------------------------
Prism contains a translation layer for ripper, which until very recently didn't emit `on_sp` tokens. This has now been implemented to improve compatibility.

However right after merging some `syntax_suggest` tests started failing: https://gist.github.com/schneems/834c75345b2085bda54dab69d913bcc0. `syntax_suggest` is using the ripper translation layer and is working around the missing `on_sp` tokens. Now that they are correctly created by prism, `syntax_suggest` is not able to handle these.

For prism this is just a bugfix but I do not want to break `syntax_suggest` unnecessarily. I asked @schneems and this is what he had to say about it: https://github.com/ruby/syntax_suggest/pull/243#issuecomment-3779113958

Backport PRs:
* 4.0 https://github.com/ruby/ruby/pull/15922
* 3.4 https://github.com/ruby/ruby/pull/15923
* 3.3 https://github.com/ruby/ruby/pull/15924



-- 
https://bugs.ruby-lang.org/
______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/