From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=0.4 required=3.0 tests=BODY_8BITS,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from nue.mailmanlists.eu (nue.mailmanlists.eu [94.130.110.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 837B01F406 for ; Tue, 22 Aug 2023 21:05:26 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=ml.ruby-lang.org header.i=@ml.ruby-lang.org header.a=rsa-sha256 header.s=mail header.b=kKfT8i+X; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=ahrTkAiq; dkim-atps=neutral Received: from nue.mailmanlists.eu (localhost [127.0.0.1]) by nue.mailmanlists.eu (Postfix) with ESMTP id 70BBD7FBF4; Tue, 22 Aug 2023 21:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ml.ruby-lang.org; s=mail; t=1692738308; bh=RAK8NaVexw1rw2dJgHf3Hzp6LHY2YZusrfF/dE1BQkA=; h=Date:References:To:Reply-To:Subject:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Cc:From; b=kKfT8i+XiH1uAw0gMOYZiUe7feLyD9usVnR6DcH9jaubqEbG4HEMQ6BWb1c+zIdN1 Az089VcuAV9ZVRu8ueFuUCPZERfhLOkxfPjn/jgmL8/b8Vo2Uc1mCblPLJCBvsXdZ1 DQx/Qlt0+thNYXWCNLMiWvdJOQEeNtIvRFkOSS0Q= Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by nue.mailmanlists.eu (Postfix) with ESMTPS id 3218F7FBA7 for ; Tue, 22 Aug 2023 21:05:02 +0000 (UTC) Authentication-Results: nue.mailmanlists.eu; dkim=pass (2048-bit key; unprotected) header.d=ruby-lang.org header.i=@ruby-lang.org header.a=rsa-sha256 header.s=s1 header.b=ahrTkAiq; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ruby-lang.org; h=from:references:subject:mime-version:content-type: content-transfer-encoding:list-id:to:cc:content-type:from:subject:to; s=s1; bh=fQRT8BR8ywn6OA4gfvMp/CD8pR+Z2057PrikHlPwQzo=; b=ahrTkAiqK3n/6zpitCHxgo5eXXtvwylasBpxCFCLgHXpHSZM/yQWcA3zDsY/vsWRqvft G9kbV3UdtDFVzQk0a5xuPQPg1DfJDcBNVJx3kXdmkwtUeYQM/VWMlMpRGo2HGBmYx5WRCm E7Rjs7yVXjyjmh3ZY64dJGOU8W3mhe/KveKfCis3dtOKms56OzW/5dAJiUTLM9Aoqh228l 24gX5Gfaz6WH54bc69Vjkzk6W+RZHWFkj3GOCMddwmUlS7MpArptWd8D7yaCZzE2HCZuwR AABz0IWirVpeY2A6wTSGjn2ro0+E1EQEsRl5TekevZgmNeh0+Vm0xOyrwAKs8G4Q== Received: by filterdrecv-66949dbc98-2wdbb with SMTP id filterdrecv-66949dbc98-2wdbb-1-64E522FD-B 2023-08-22 21:05:01.081397667 +0000 UTC m=+8976308.368646030 Received: from herokuapp.com (unknown) by geopod-ismtpd-4 (SG) with ESMTP id NbwmtIxRRBeEX_W-7e7hWw for ; Tue, 22 Aug 2023 21:05:01.065 +0000 (UTC) Date: Tue, 22 Aug 2023 21:05:01 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 8782 X-Redmine-Issue-Author: naruse X-Redmine-Issue-Assignee: kouji X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 90947 X-SG-EID: =?us-ascii?Q?zy3UxWTRryXcrjCh7SV39ZkShJ1PHkEOmoUEekBgd8G8RAJk=2FsUOlbLwuWEoNU?= =?us-ascii?Q?BxG3BBFmcsr21OPpQwa7zNRSwswJm1szgMd841w?= =?us-ascii?Q?HPqc4P4SEsTAbw7kCU5aoEMa3NxyIhqlKWmQwwy?= =?us-ascii?Q?oFp9oVzZbA1ojTgUQ4LsipaUWpR=2F2YtEfpbLde6?= =?us-ascii?Q?4qdWessEhRt7D7Rue5z8kSIDQoGC4hIf2n4C=2FYZ?= =?us-ascii?Q?6sSUo9SxLZCrB5thljG1+WkTZQktM9w6MrXJYqp?= =?us-ascii?Q?ijXOQC8L7YqZfzrRIXPGg=3D=3D?= To: ruby-dev@ml.ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== Message-ID-Hash: PQQGCZN47BARO6TUCKOW3YDSTAHH6VKR X-Message-ID-Hash: PQQGCZN47BARO6TUCKOW3YDSTAHH6VKR X-MailFrom: bounces+313651-12dc-ruby-dev=ml.ruby-lang.org@em5188.ruby-lang.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list Reply-To: "Ruby developers (Japanese)" Subject: =?utf-8?q?=5Bruby-dev=3A52038=5D_?= [Ruby master Bug#8782] Don't set rl_getc_function on editline List-Id: "Ruby developers (Japanese)" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: "jeremyevans0 (Jeremy Evans) via ruby-dev" Cc: "jeremyevans0 (Jeremy Evans)" Issue #8782 has been updated by jeremyevans0 (Jeremy Evans).=0D =0D Status changed from Assigned to Closed=0D Backport deleted (1.9.3: UNKNOWN, 2.0.0: UNKNOWN)=0D =0D Readline support was removed in commit:59fd67fc3d405e529e038172e769ff20a8fb= 5535. If this is still an issue, please file it upstream https://github.co= m/ruby/readline-ext=0D =0D ----------------------------------------=0D Bug #8782: Don't set rl_getc_function on editline=0D https://bugs.ruby-lang.org/issues/8782#change-104205=0D =0D * Author: naruse (Yui NARUSE)=0D * Status: Closed=0D * Priority: Normal=0D * Assignee: kouji (Kouji Takao)=0D * ruby -v: ruby 2.1.0dev (2013-08-12 trunk 42528) [x86_64-darwin12.4.0]=0D ----------------------------------------=0D r42402 =E4=BB=A5=E6=9D=A5 OS X =E7=AD=89=E3=81=AE editline =E7=92=B0=E5=A2= =83=E3=81=A7=E3=81=AF #define rl_getc(f) EOF =E3=81=8C=E4=BD=BF=E3=82=8F=E3= =82=8C=E3=82=8B=E3=82=88=E3=81=86=E3=81=AB=E3=81=AA=E3=81=A3=E3=81=A6=E3=81= =97=E3=81=BE=E3=81=A3=E3=81=A6=E6=AE=8B=E5=BF=B5=E3=81=AA=E3=81=93=E3=81=A8= =E3=81=AB=E3=81=AA=E3=81=A3=E3=81=A6=E3=81=84=E3=81=9F=E3=82=8F=E3=81=91=E3= =81=A7=E3=81=99=E3=81=8C=E3=80=81=0D =E3=81=9D=E3=82=82=E3=81=9D=E3=82=82 editline =E3=81=AE readline wrapper = =E3=81=AF non ASCII =E3=81=AB=E5=AF=BE=E5=BF=9C=E3=81=97=E3=81=A6=E3=81=84= =E3=81=BE=E3=81=9B=E3=82=93=E3=80=82=0D (editline =E8=87=AA=E4=BD=93=E3=81=AB=E3=81=AF UTF-8 =E3=81=AE=E3=81=BF=E3= =81=AE=E5=AF=BE=E5=BF=9C=E3=81=8C=E5=85=A5=E3=81=A3=E3=81=9F=E3=81=8C=E3=80= =81readline wrapper =E3=81=AF src/readline.c =E3=81=AE _getc_function =E3= =82=92=E7=B5=8C=E7=94=B1=E3=81=99=E3=82=8B=E3=81=AE=E3=81=A7 non ASCII =E3= =81=AF=E5=8C=96=E3=81=91=E3=82=8B)=0D =0D =E3=81=AE=E3=81=A7=E3=80=81=E3=81=84=E3=81=A3=E3=81=9D rl_getc_function =E3= =82=92=E4=BD=BF=E3=82=8F=E3=81=AA=E3=81=84=E3=82=88=E3=81=86=E3=81=AB=E3=81= =97=E3=81=A6=E3=81=AF=E3=81=A9=E3=81=86=E3=81=A7=E3=81=97=E3=82=87=E3=81=86= =E3=80=82=0D =E4=BB=A5=E4=B8=8B=E3=81=AE=E3=82=88=E3=81=86=E3=81=AA=E3=83=91=E3=83=83=E3= =83=81=E3=82=92=E5=BD=93=E3=81=A6=E3=82=8B=E3=81=A8=E3=80=81readline =E3=81= =AA=E3=81=97=E3=81=AE OS X =E3=81=AE irb =E3=81=A7=E6=97=A5=E6=9C=AC=E8=AA= =9E=E3=81=8C=E4=BD=BF=E3=81=88=E3=82=8B=E3=82=88=E3=81=86=E3=81=AB=E3=81=AA= =E3=82=8A=E3=81=BE=E3=81=99=E3=80=82=0D =0D diff --git a/ext/readline/extconf.rb b/ext/readline/extconf.rb=0D index 0b121c1..bc0ee77 100644=0D --- a/ext/readline/extconf.rb=0D +++ b/ext/readline/extconf.rb=0D @@ -94,4 +94,5 @@ readline.have_func("clear_history")=0D readline.have_func("rl_redisplay")=0D readline.have_func("rl_insert_text")=0D readline.have_func("rl_delete_text")=0D +readline.have_func("el_init")=0D create_makefile("readline")=0D diff --git a/ext/readline/readline.c b/ext/readline/readline.c=0D index 0f76d1a..85109f0 100644=0D --- a/ext/readline/readline.c=0D +++ b/ext/readline/readline.c=0D @@ -130,12 +130,7 @@ static VALUE readline_instream;=0D static VALUE readline_outstream;=0D =0D #if defined HAVE_RL_GETC_FUNCTION=0D -=0D -#ifndef HAVE_RL_GETC=0D -#define rl_getc(f) EOF=0D -#endif=0D -=0D -static int readline_getc(FILE *);=0D +# ifndef HAVE_EL_INIT=0D static int=0D readline_getc(FILE *input)=0D {=0D @@ -187,6 +182,7 @@ readline_getc(FILE *input)=0D #endif=0D return FIX2INT(c);=0D }=0D +# endif=0D #elif defined HAVE_RL_EVENT_HOOK=0D #define BUSY_WAIT 0=0D =0D @@ -1771,7 +1767,9 @@ Init_readline()=0D /* libedit check rl_getc_function only when rl_initialize() is called,= */=0D /* and using_history() call rl_initialize(). */=0D /* This assignment should be placed before using_history() */=0D +# ifndef HAVE_EL_INIT=0D rl_getc_function =3D readline_getc;=0D +# endif=0D #elif defined HAVE_RL_EVENT_HOOK=0D rl_event_hook =3D readline_event;=0D #endif=0D =0D =0D =0D =0D --=20=0D https://bugs.ruby-lang.org/=0D