[ruby-dev:50941] [Ruby master Bug#17094] PTY methods with blocks

[ruby-dev:50941] [Ruby master Bug#17094] PTY methods with blocks

[matsumoto]

Issue #17094 has been reported by soutaro (Soutaro Matsumoto).

----------------------------------------
Bug #17094: PTY methods with blocks
https://bugs.ruby-lang.org/issues/17094

* Author: soutaro (Soutaro Matsumoto)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Some methods on PTY yields one array if a block is given, but the RDoc says it passes two arguments to the block.

https://github.com/ruby/ruby/blob/master/ext/pty/pty.c#L529
``` c
return rb_ensure(rb_yield, assoc, pty_close_pty, assoc);
```

https://github.com/ruby/ruby/blob/master/ext/pty/pty.c#L467
```
 *   PTY.open {|master_io, slave_file| ... } => block value
```

I'd like to propose to fix the implementation. However, it would make more sense to fix the docs because of potential incompatibilities.



-- 
https://bugs.ruby-lang.org/

[ruby-dev:50942] [Ruby master Bug#17094] PTY methods with blocks

[nobu]

Issue #17094 has been updated by nobu (Nobuyoshi Nakada).


As it can be incompatible only when passing a lambda, I don't think it is a serious problem.

----------------------------------------
Bug #17094: PTY methods with blocks
https://bugs.ruby-lang.org/issues/17094#change-86862

* Author: soutaro (Soutaro Matsumoto)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Some methods on PTY yields one array if a block is given, but the RDoc says it passes two arguments to the block.

https://github.com/ruby/ruby/blob/master/ext/pty/pty.c#L529
``` c
return rb_ensure(rb_yield, assoc, pty_close_pty, assoc);
```

https://github.com/ruby/ruby/blob/master/ext/pty/pty.c#L467
```
 *   PTY.open {|master_io, slave_file| ... } => block value
```

I'd like to propose to fix the implementation. However, it would make more sense to fix the docs because of potential incompatibilities.



-- 
https://bugs.ruby-lang.org/

[ruby-dev:50943] [Ruby master Bug#17094] PTY methods with blocks

[matsumoto]

Issue #17094 has been updated by soutaro (Soutaro Matsumoto).


Runtime testing of RBS uncovered this issue.

https://github.com/ruby/rbs/pull/346#issuecomment-665817340

Maybe we can fix the RBS runtime checking then.

----------------------------------------
Bug #17094: PTY methods with blocks
https://bugs.ruby-lang.org/issues/17094#change-86884

* Author: soutaro (Soutaro Matsumoto)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Some methods on PTY yields one array if a block is given, but the RDoc says it passes two arguments to the block.

https://github.com/ruby/ruby/blob/master/ext/pty/pty.c#L529
``` c
return rb_ensure(rb_yield, assoc, pty_close_pty, assoc);
```

https://github.com/ruby/ruby/blob/master/ext/pty/pty.c#L467
```
 *   PTY.open {|master_io, slave_file| ... } => block value
```

I'd like to propose to fix the implementation. However, it would make more sense to fix the docs because of potential incompatibilities.



-- 
https://bugs.ruby-lang.org/