ruby-dev (Japanese) list archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-dev:50944] [Ruby master Feature#17099] Remove Module#attr warning with given boolean argument
@ 2020-08-02 16:51 gamelinks007
  2020-08-29 13:38 ` [ruby-dev:50952] [Ruby master Feature#17099] Remove boolean argument and warning from Module#attr gamelinks007
  2020-12-18  4:15 ` [ruby-dev:50979] " nobu
  0 siblings, 2 replies; 3+ messages in thread
From: gamelinks007 @ 2020-08-02 16:51 UTC (permalink / raw)
  To: ruby-dev

Issue #17099 has been reported by S_H_ (Shun Hiraoka).

----------------------------------------
Feature #17099: Remove Module#attr warning with given boolean argument
https://bugs.ruby-lang.org/issues/17099

* Author: S_H_ (Shun Hiraoka)
* Status: Open
* Priority: Normal
----------------------------------------
`Module#attr` works as `Module#attr_reader` by default(since in `1.9.1`).
And, optional boolean argument is obsoleted(But, it works as `Module#attr_writer` given optional argument `true`).

I think it's okey to remove `Module#attr` warning (with given optional boolean argument).





-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-dev:50952] [Ruby master Feature#17099] Remove boolean argument and warning from Module#attr
  2020-08-02 16:51 [ruby-dev:50944] [Ruby master Feature#17099] Remove Module#attr warning with given boolean argument gamelinks007
@ 2020-08-29 13:38 ` gamelinks007
  2020-12-18  4:15 ` [ruby-dev:50979] " nobu
  1 sibling, 0 replies; 3+ messages in thread
From: gamelinks007 @ 2020-08-29 13:38 UTC (permalink / raw)
  To: ruby-dev

Issue #17099 has been updated by S_H_ (Shun Hiraoka).



Anyone has opinion?

----------------------------------------
Feature #17099: Remove boolean argument and warning from Module#attr
https://bugs.ruby-lang.org/issues/17099#change-87285

* Author: S_H_ (Shun Hiraoka)
* Status: Open
* Priority: Normal
----------------------------------------
`Module#attr` works as `Module#attr_reader` by default (since in 1.9.1). Its optional boolean argument is obsoleted, but it works as `Module#attr_writer` when its value is `true`.

I think it's okay to remove the optional boolean argument and the warning from `Module#attr`.

pull request:
https://github.com/ruby/ruby/pull/3386



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-dev:50979] [Ruby master Feature#17099] Remove boolean argument and warning from Module#attr
  2020-08-02 16:51 [ruby-dev:50944] [Ruby master Feature#17099] Remove Module#attr warning with given boolean argument gamelinks007
  2020-08-29 13:38 ` [ruby-dev:50952] [Ruby master Feature#17099] Remove boolean argument and warning from Module#attr gamelinks007
@ 2020-12-18  4:15 ` nobu
  1 sibling, 0 replies; 3+ messages in thread
From: nobu @ 2020-12-18  4:15 UTC (permalink / raw)
  To: ruby-dev

Issue #17099 has been updated by nobu (Nobuyoshi Nakada).


It has not been warned unless `$VERBOSE` yet.
We may need wait one more release if we obey the previous rule.
But deprecations aren't warned even if `$VERBOSE` since 2.7.2, I think we can reconsider that rule.

----------------------------------------
Feature #17099: Remove boolean argument and warning from Module#attr
https://bugs.ruby-lang.org/issues/17099#change-89286

* Author: S_H_ (Shun Hiraoka)
* Status: Open
* Priority: Normal
----------------------------------------
`Module#attr` works as `Module#attr_reader` by default (since in 1.9.1). Its optional boolean argument is obsoleted, but it works as `Module#attr_writer` when its value is `true`.

I think it's okay to remove the optional boolean argument and the warning from `Module#attr`.

pull request:
https://github.com/ruby/ruby/pull/3386



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-18  4:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 16:51 [ruby-dev:50944] [Ruby master Feature#17099] Remove Module#attr warning with given boolean argument gamelinks007
2020-08-29 13:38 ` [ruby-dev:50952] [Ruby master Feature#17099] Remove boolean argument and warning from Module#attr gamelinks007
2020-12-18  4:15 ` [ruby-dev:50979] " nobu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).