From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id CD9081F8C6 for ; Tue, 10 Aug 2021 23:00:29 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id CB8581209E6; Wed, 11 Aug 2021 07:59:07 +0900 (JST) Received: from xtrwkhkc.outbound-mail.sendgrid.net (xtrwkhkc.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id ED94E1209E6 for ; Wed, 11 Aug 2021 07:59:05 +0900 (JST) Received: by filterdrecv-559d787d5b-4lmk2 with SMTP id filterdrecv-559d787d5b-4lmk2-1-611304FD-F 2021-08-10 23:00:13.361390035 +0000 UTC m=+544003.539354122 Received: from herokuapp.com (unknown) by ismtpd0150p1iad2.sendgrid.net (SG) with ESMTP id hnNpFM4gTDuFGPq0KEk25A for ; Tue, 10 Aug 2021 23:00:13.248 +0000 (UTC) Date: Tue, 10 Aug 2021 23:00:13 +0000 (UTC) From: merch-redmine@jeremyevans.net Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Redmine-Project: ruby-master X-Redmine-Issue-Tracker: Bug X-Redmine-Issue-Id: 12540 X-Redmine-Issue-Author: znz X-Redmine-Sender: jeremyevans0 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-Redmine-MailingListIntegration-Message-Ids: 81007 X-SG-EID: =?us-ascii?Q?RVE3t853K5scBhbmJHUzZTFFeVC=2FZSUmHZ0Dc+26wcEi2CTgsF1oz0wTSSxGGN?= =?us-ascii?Q?BI7FXibPO=2FYz8FJ=2F7JMfyvgvi3QWV1VOPeL2YyT?= =?us-ascii?Q?FaGYRgCO8KugdImeXnSMJeHiPssMd5lJ5LVd9sS?= =?us-ascii?Q?6kIAKeHfsWS414bdVPI59A1hHP6jrH60R0i0gTO?= =?us-ascii?Q?6iM107WZLLubWGqQno02GTBSL3noUvQb9DIB6Bm?= =?us-ascii?Q?qCCAAHHwMm=2Fh=2FVSfw=3D?= To: ruby-dev@ruby-lang.org X-Entity-ID: b/2+PoftWZ6GuOu3b0IycA== X-ML-Name: ruby-dev X-Mail-Count: 51093 Subject: [ruby-dev:51093] [Ruby master Bug#12540] test failures when SHARABLE_MIDDLE_SUBSTRING=1 X-BeenThere: ruby-dev@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: "Ruby developers \(Japanese\)" List-Id: "Ruby developers \(Japanese\)" List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: ruby-dev-bounces@ruby-lang.org Sender: "ruby-dev" Issue #12540 has been updated by jeremyevans0 (Jeremy Evans).=0D =0D =0D I think this was caused by commit:a707ab4bc8a29241440f56696098efa2f7f3ff45,= which removed the term filling if SHARABLE_MIDDLE_SUBSTRING was enabled. I= submitted a pull request that basically reverts that commit: https://githu= b.com/ruby/ruby/pull/4731. I think the term filling can still be done safe= ly, because the places where it was used already call `str_modify_keep_cr`,= which should ensure they are dealing with a unique memory buffer.=0D =0D ----------------------------------------=0D Bug #12540: test failures when SHARABLE_MIDDLE_SUBSTRING=3D1=0D https://bugs.ruby-lang.org/issues/12540#change-93226=0D =0D * Author: znz (Kazuhiro NISHIYAMA)=0D * Status: Open=0D * Priority: Normal=0D * ruby -v: ruby 2.4.0dev (2016-07-02 trunk 55562) [x86_64-linux]=0D * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN=0D ----------------------------------------=0D SHARABLE_MIDDLE_SUBSTRING=3D1 =E3=81=A7=E3=83=93=E3=83=AB=E3=83=89=E3=81=99= =E3=82=8B=E3=81=A8 Test_StringCStr#test_wchar_lstrip!,Test_StringCStr#test_= wchar_rstrip! =E3=81=8C=E5=A4=B1=E6=95=97=E3=81=97=E3=81=BE=E3=81=99=E3=80= =82=0D =0D ~~~=0D [16604/16757] Test_StringCStr#test_wchar_lstrip! =3D 0.00 s=0D 3) Failure:=0D Test_StringCStr#test_wchar_lstrip! [/home/vagrant/ruby/test/-ext-/string/te= st_cstr.rb:81]:=0D Expected {#=3D>"a",=0D #=3D>"a",=0D #=3D>"a",=0D #=3D>"a"} to be empty.=0D =0D [16606/16757] Test_StringCStr#test_wchar_rstrip! =3D 0.00 s=0D 4) Failure:=0D Test_StringCStr#test_wchar_rstrip! [/home/vagrant/ruby/test/-ext-/string/te= st_cstr.rb:85]:=0D Expected {#=3D>" ",=0D #=3D>" ",=0D #=3D>" ",=0D #=3D>" "} to be empty.=0D ~~~=0D =0D =E5=8E=9F=E5=9B=A0=E3=82=92=E8=AA=BF=E3=81=B9=E3=81=A6=E3=81=BF=E3=81=9F=E3= =81=A8=E3=81=93=E3=82=8D=E3=80=81lstrip!,rstrip! =E3=81=A0=E3=81=91 !SHARAB= LE_MIDDLE_SUBSTRING =E3=81=A7 TERM_FILL =E3=82=92=E3=81=8F=E3=81=8F=E3=81= =A3=E3=81=A6=E3=81=84=E3=82=8B=E3=81=8B=E3=82=89=E3=81=AE=E3=82=88=E3=81=86= =E3=81=A7=E3=81=97=E3=81=9F=E3=80=82=0D =0D =E8=AA=BF=E3=81=B9=E3=81=A6=E3=81=84=E3=81=A6=E6=80=9D=E3=81=A3=E3=81=9F=E3= =81=AE=E3=81=A7=E3=81=99=E3=81=8C=E3=80=81=E5=80=8B=E5=88=A5=E3=81=AB TERM_= FILL =E3=82=92=E5=91=BC=E3=81=B6=E3=81=8B=E3=81=A9=E3=81=86=E3=81=8B=E3=82= =92=E5=88=86=E5=B2=90=E3=81=99=E3=82=8B=E3=82=88=E3=82=8A=E3=82=82=E3=80=81= SHARABLE_MIDDLE_SUBSTRING =E3=81=AE=E5=80=A4=E3=81=AB=E3=82=88=E3=81=A3=E3= =81=A6 TERM_FILL =E8=87=AA=E4=BD=93=E3=81=AE=E5=AE=9A=E7=BE=A9=E3=82=92=E5= =A4=89=E6=9B=B4=E3=81=99=E3=82=8B=E3=82=88=E3=81=86=E3=81=AB=E3=81=97=E3=81= =9F=E6=96=B9=E3=81=8C=E8=89=AF=E3=81=84=E3=81=AE=E3=81=A7=E3=81=AF=E3=81=AA= =E3=81=84=E3=81=A7=E3=81=97=E3=82=87=E3=81=86=E3=81=8B?=0D =0D =0D =0D --=20=0D https://bugs.ruby-lang.org/=0D