ruby-dev (Japanese) list archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "mrkn (Kenta Murata)" <noreply@ruby-lang.org>
To: ruby-dev@ruby-lang.org
Subject: [ruby-dev:51190] [Ruby master Bug#18953] `Array#uniq` doesn't evaluate the given block when the size of the array is one
Date: Wed, 03 Aug 2022 04:52:56 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-98570.20220803045255.12651@ruby-lang.org> (raw)
In-Reply-To: <redmine.issue-18953.20220802021548.12651@ruby-lang.org>

Issue #18953 has been updated by mrkn (Kenta Murata).


I hope this behavior should be expected.
However, `sort_by`, `max_by`, and `min_by` call the given blocks even if the receiver array has only one item.

```
irb(main):001:0> [42].sort_by { _1.foo }
(irb):1:in `block in <top (required)>': undefined method `foo' for 42:Integer (NoMethodError)
Did you mean?  floor
	from (irb):1:in `each'
	from (irb):1:in `sort_by'
	from (irb):1:in `<main>'
	from /home/mrkn/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
	from /home/mrkn/.rbenv/versions/3.1.0/bin/irb:25:in `load'
	from /home/mrkn/.rbenv/versions/3.1.0/bin/irb:25:in `<main>'
irb(main):002:0> [42].max_by { _1.foo }
(irb):2:in `block in <top (required)>': undefined method `foo' for 42:Integer (NoMethodError)
Did you mean?  floor
	from (irb):2:in `each'
	from (irb):2:in `max_by'
	from (irb):2:in `<main>'
	from /home/mrkn/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
	from /home/mrkn/.rbenv/versions/3.1.0/bin/irb:25:in `load'
	from /home/mrkn/.rbenv/versions/3.1.0/bin/irb:25:in `<main>'
irb(main):003:0> [42].min_by { _1.foo }
(irb):3:in `block in <top (required)>': undefined method `foo' for 42:Integer (NoMethodError)
Did you mean?  floor
	from (irb):3:in `each'
	from (irb):3:in `min_by'
	from (irb):3:in `<main>'
	from /home/mrkn/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
	from /home/mrkn/.rbenv/versions/3.1.0/bin/irb:25:in `load'
	from /home/mrkn/.rbenv/versions/3.1.0/bin/irb:25:in `<main>'
```

----------------------------------------
Bug #18953: `Array#uniq` doesn't evaluate the given block when the size of the array is one
https://bugs.ruby-lang.org/issues/18953#change-98570

* Author: ttanimichi (Tsukuru Tanimichi)
* Status: Open
* Priority: Normal
* ruby -v: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
`Array#uniq` doesn't evaluate the given block when the size of the array is one. Is this expected behavior?

```
$ ruby -e '[42, 43].uniq { _1.foo }; puts true'
-e:1:in `block in <main>': undefined method `foo' for 42:Integer (NoMethodError)

[42, 43].uniq { _1.foo }; puts true
                  ^^^^
Did you mean?  floor
	from -e:1:in `uniq'
	from -e:1:in `<main>'
```

```
$ ruby -e '[42].uniq { _1.foo }; puts true'
true
```




-- 
https://bugs.ruby-lang.org/

  reply	other threads:[~2022-08-03  4:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  2:15 [ruby-dev:51189] " ttanimichi (Tsukuru Tanimichi)
2022-08-03  4:52 ` mrkn (Kenta Murata) [this message]
2022-08-03  6:12 ` [ruby-dev:51191] " nobu (Nobuyoshi Nakada)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-98570.20220803045255.12651@ruby-lang.org \
    --to=noreply@ruby-lang.org \
    --cc=ruby-dev@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).