From: "Mark H. Wilkinson" <mhw@kremvax.demon.co.uk>
To: bobf@research.bell-labs.com
Cc: sam-fans@hawkwind.utcs.toronto.edu
Subject: libXg bug fix
Date: Tue, 15 Sep 1998 19:03:28 -0400 [thread overview]
Message-ID: <199809160003.28896.out.badoz@kremvax.demon.co.uk> (raw)
This fixes a bug in ffree() in sam's libXg. c is a pointer to a
structure within an array of such structures, and as such shouldn't
be free'd. The later call to free(f->subf) frees the whole array.
I should point out that sam doesn't actually call ffree() anywhere,
so it's not going to fall over because of this. Other programs might.
-Mark.
Index: rdfontfile.c
===================================================================
RCS file: /u/cvs/9libs/libXg/rdfontfile.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -C4 -r1.4 -r1.5
*** rdfontfile.c 1998/08/11 00:20:44 1.4
--- rdfontfile.c 1998/09/15 23:03:22 1.5
***************
*** 126,134 ****
c = f->subf+i;
if (c->f)
subffree(c->f);
free(c->name);
- free(c);
}
free(f->subf);
free(f);
}
--- 126,133 ----
reply other threads:[~1998-09-17 6:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199809160003.28896.out.badoz@kremvax.demon.co.uk \
--to=mhw@kremvax.demon.co.uk \
--cc=bobf@research.bell-labs.com \
--cc=sam-fans@hawkwind.utcs.toronto.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).