From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 6824 invoked from network); 26 Sep 2023 01:00:37 -0000
Received: from alyss.skarnet.org (95.142.172.232)
  by inbox.vuxu.org with ESMTPUTF8; 26 Sep 2023 01:00:37 -0000
Received: (qmail 56137 invoked by uid 89); 26 Sep 2023 01:01:02 -0000
Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm
Sender: <supervision@list.skarnet.org>
Precedence: bulk
List-Post: <mailto:supervision@list.skarnet.org>
List-Help: <mailto:supervision-help@list.skarnet.org>
List-Unsubscribe: <mailto:supervision-unsubscribe@list.skarnet.org>
List-Subscribe: <mailto:supervision-subscribe@list.skarnet.org>
List-Id: <supervision.list.skarnet.org>
Received: (qmail 56130 invoked from network); 26 Sep 2023 01:01:01 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=westernsemico.com; s=default; h=Message-ID:Date:To:From:Subject:References:
	In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type:Sender:
	Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:
	List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=8xneMynyTVAJRKGJ9xSo9m1cplBD5DWLqARHRUDPupk=; b=dy25ThVQnkq2aRiZYzATA7+4B9
	vF0AumeFv/Zg61DF+8vZoyYOlrI05jWK18f1OOOi+ot460jnplU6xNOzUALqMsewpu2tsk+rhUap6
	zvpFPrrikryqMwSOVB09bTy8gvv41ynjTkp890M5R5lKWc0yCIiIRiHksyoM5h37I7stQ74ZHUwyp
	OBoZe+m1+PNiekIolX+IOD/58rR5yl1sQ+h1S09hE18wTmRmepyfzzX5jqF/lzi1E/Fnp5Muk2R9e
	Gy+b/F0nCpzrLWGaP4eftg3ESMrUrc/IBGEvF/tFghWFxmfYguCyV5EJdOdeXEuOteP9RPJtYzQ1m
	r7uGKxBQ==;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230926004418.24990-3-adam@westernsemico.com>
References: <20230926004418.24990-1-adam@westernsemico.com> <20230926004418.24990-3-adam@westernsemico.com>
Subject: Re: [PATCH 3/3] [WIP] s6-rc-update.c: add additional comments
From: Adam Joseph <adam@westernsemico.com>
To: supervision@list.skarnet.org
Date: Mon, 25 Sep 2023 17:59:56 -0700
Message-ID: <169568999649.6030.13558663157321709514@localhost>
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - server220.web-hosting.com
X-AntiAbuse: Original Domain - list.skarnet.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - westernsemico.com
X-Get-Message-Sender-Via: server220.web-hosting.com: authenticated_id: westwhdn/from_h
X-Authenticated-Sender: server220.web-hosting.com: adam@westernsemico.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-From-Rewrite: unmodified, already matched

Quoting Adam Joseph (2023-09-25 17:44:18)
> +      /*
> +        Note: the following will fail if you have a singleton bundle
> +        and try to rename both the bundle and the thing it contains
> +        in the same s6-rc-update invocation.  Parts of this loop
> +        should probably be skipped for singleton bundles.
> +      */

I'm working on a minimal example of this issue and a fix, but it might be a=
 few
days before I have something worth submitting.