Confused about use of finish

Confused about use of finish

[oss-packages]

Hi,

I don't quite understand the intended purpose of the finish scripts.
In my experience using runit 1.0.1 under GNU/Linux, finish is not called
when runsv receives the exit command. There is an inconsistency in my
view between the 'down' behavior and the 'exit' behavior: in the former
case, finish is executed, in the latter it is not.

At system shutdown, I'd expect that the finish scripts should be executed
to clean up everything, but since shutdown sends the exit command to
runsv, this doesn't happen. I shut down by running init 0 or init 6.

Looking at the runsv code, I'm even more puzzled: when runsv receives the
exit command, it checks for the presence of finish, and sets the status
to 'finish, want exit', but it doesn't actually run finish. Basically
it seems there is no difference whether finish exists or not, except if
it doesn't exist, the status is set to 'down, want exit'.

In the sample scripts for stage 3, svwaitdown is used to perform a last
chance orderly shutdown of the services. svwaitdown is supposed to send
the down command, so finish should be executed then. But typically all my
services have already terminated by the time svwaitdown runs in stage 3,
so it doesn't do anything.

I'd appreciate hearing your comments and clarifications about this.
Thanks,
X.

Re: Confused about use of finish

[Gerrit Pape]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Sun, Mar 21, 2004 at 03:23:14PM -0000, oss-packages@xavier.stonestreet.name wrote:
> In my experience using runit 1.0.1 under GNU/Linux, finish is not called
> when runsv receives the exit command. There is an inconsistency in my
> view between the 'down' behavior and the 'exit' behavior: in the former
> case, finish is executed, in the latter it is not.

> I'd appreciate hearing your comments and clarifications about this.

I share your view, and say it's a bug.  runsv should run the ./finish
script when told to bring the service down and exit, it will be fixed in
1.0.2.

Thanks for reporting this, Gerrit.

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 584 bytes --]

Index: src/runsv.c
===================================================================
RCS file: /var/lib/cvs/runit/src/runsv.c,v
retrieving revision 1.16
diff -u -r1.16 runsv.c
--- src/runsv.c	2 Mar 2004 20:42:56 -0000	1.16
+++ src/runsv.c	21 Mar 2004 18:05:22 -0000
@@ -512,7 +512,7 @@
     if (haslog)
       if (read(svd[1].fdcontrol, &ch, 1) == 1) ctrl(&svd[1], ch);
 
-    if (svd[0].want == W_EXIT && svd[0].pid == 0) {
+    if (svd[0].want == W_EXIT && svd[0].state == S_DOWN) {
       if (svd[1].pid == 0) _exit(0);
       if (svd[1].want != W_EXIT) {
 	svd[1].want =W_EXIT;