supervision - discussion about system services, daemon supervision, init, runlevel management, and tools such as s6 and runit
 help / color / mirror / Atom feed
From: Gerrit Pape <pape@smarden.org>
Cc: supervision@list.skarnet.org
Subject: Re: Bug in gpape's ipsvd
Date: Thu, 8 Jul 2004 18:05:58 +0000	[thread overview]
Message-ID: <20040708180619.4530.qmail@ae39214f33d496.315fe32.mid.smarden.org> (raw)
In-Reply-To: <9B82FDA0C3DCED5F1C8737D9@[192.168.10.2]>

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Sun, Jul 04, 2004 at 07:08:44PM +0100, Torne wrote:
> tcpsvd interprets an instruction of 'C0' for a particular host as meaning 
> 'no connections', whereas the documentation states that this should allow 
> unlimited connections up to the global limit. This situation only arises 
> when there is a global per-host concurrency limit which is being overridden 
> for particular IPs. Patch below.

Yes, thanks a lot for pointing this out.  See below for a slightly
updated patch; if per host concurrency isn't enabled globally,
concurrency instructions must be ignored.

Regards, Gerrit.

PS: You're on the wrong list.

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 444 bytes --]

Index: src/tcpsvd.c
===================================================================
RCS file: /var/lib/cvs/ipsvd/src/tcpsvd.c,v
retrieving revision 1.21
diff -u -r1.21 tcpsvd.c
--- src/tcpsvd.c	13 Feb 2004 13:19:01 -0000	1.21
+++ src/tcpsvd.c	7 Jul 2004 11:16:09 -0000
@@ -172,7 +172,7 @@
   }
   else ac =IPSVD_DEFAULT;
 
-  if (phcc > 0) {
+  if (phcc && phccmax) {
     if (phcc > phccmax) {
       ac =IPSVD_DENY;
       if (phccmsg) {

      reply	other threads:[~2004-07-08 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-04 18:08 Torne
2004-07-08 18:05 ` Gerrit Pape [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040708180619.4530.qmail@ae39214f33d496.315fe32.mid.smarden.org \
    --to=pape@smarden.org \
    --cc=supervision@list.skarnet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).