Bug in gpape's ipsvd

Bug in gpape's ipsvd

[Torne]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

tcpsvd interprets an instruction of 'C0' for a particular host as meaning 
'no connections', whereas the documentation states that this should allow 
unlimited connections up to the global limit. This situation only arises 
when there is a global per-host concurrency limit which is being overridden 
for particular IPs. Patch below.

--- tcpsvd.c.orig       2004-07-04 19:00:56.000000000 +0100
+++ tcpsvd.c    2004-07-04 19:01:15.000000000 +0100
@@ -172,7 +172,7 @@
   }
   else ac =IPSVD_DEFAULT;

-  if (phcc > 0) {
+  if (phccmax > 0) {
     if (phcc > phccmax) {
       ac =IPSVD_DENY;
       if (phccmsg) {


-- 
Torne (torne@wolfpuppy.org.uk)
Wolf puppy, coder and social engineer.

[-- Attachment #2: Type: application/pgp-signature, Size: 187 bytes --]

Re: Bug in gpape's ipsvd

[Gerrit Pape]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Sun, Jul 04, 2004 at 07:08:44PM +0100, Torne wrote:
> tcpsvd interprets an instruction of 'C0' for a particular host as meaning 
> 'no connections', whereas the documentation states that this should allow 
> unlimited connections up to the global limit. This situation only arises 
> when there is a global per-host concurrency limit which is being overridden 
> for particular IPs. Patch below.

Yes, thanks a lot for pointing this out.  See below for a slightly
updated patch; if per host concurrency isn't enabled globally,
concurrency instructions must be ignored.

Regards, Gerrit.

PS: You're on the wrong list.

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 444 bytes --]

Index: src/tcpsvd.c
===================================================================
RCS file: /var/lib/cvs/ipsvd/src/tcpsvd.c,v
retrieving revision 1.21
diff -u -r1.21 tcpsvd.c
--- src/tcpsvd.c	13 Feb 2004 13:19:01 -0000	1.21
+++ src/tcpsvd.c	7 Jul 2004 11:16:09 -0000
@@ -172,7 +172,7 @@
   }
   else ac =IPSVD_DEFAULT;
 
-  if (phcc > 0) {
+  if (phcc && phccmax) {
     if (phcc > phccmax) {
       ac =IPSVD_DENY;
       if (phccmsg) {