From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/511 Path: main.gmane.org!not-for-mail From: Gerrit Pape Newsgroups: gmane.comp.sysutils.supervision.general,gmane.comp.misc.pape.general Subject: Re: Bug in gpape's ipsvd Date: Thu, 8 Jul 2004 18:05:58 +0000 Message-ID: <20040708180619.4530.qmail@ae39214f33d496.315fe32.mid.smarden.org> References: <9B82FDA0C3DCED5F1C8737D9@[192.168.10.2]> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Fig2xvG2VGoz8o/s" X-Trace: sea.gmane.org 1089309977 18291 80.91.224.253 (8 Jul 2004 18:06:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Jul 2004 18:06:17 +0000 (UTC) Cc: supervision@list.skarnet.org Original-X-From: supervision-return-749-gcsg-supervision=m.gmane.org@list.skarnet.org Thu Jul 08 20:06:07 2004 Return-path: Original-Received: from antah.skarnet.org ([212.85.147.14]) by deer.gmane.org with smtp (Exim 3.35 #1 (Debian)) id 1BidHb-00060m-00 for ; Thu, 08 Jul 2004 20:06:07 +0200 Original-Received: (qmail 3625 invoked by uid 76); 8 Jul 2004 18:06:24 -0000 Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Archive: Original-Received: (qmail 3620 invoked from network); 8 Jul 2004 18:06:24 -0000 Original-To: misc@list.smarden.org Mail-Followup-To: misc@list.smarden.org Content-Disposition: inline In-Reply-To: <9B82FDA0C3DCED5F1C8737D9@[192.168.10.2]> Xref: main.gmane.org gmane.comp.sysutils.supervision.general:511 gmane.comp.misc.pape.general:794 X-Report-Spam: http://spam.gmane.org/gmane.comp.sysutils.supervision.general:511 --Fig2xvG2VGoz8o/s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jul 04, 2004 at 07:08:44PM +0100, Torne wrote: > tcpsvd interprets an instruction of 'C0' for a particular host as meaning > 'no connections', whereas the documentation states that this should allow > unlimited connections up to the global limit. This situation only arises > when there is a global per-host concurrency limit which is being overridden > for particular IPs. Patch below. Yes, thanks a lot for pointing this out. See below for a slightly updated patch; if per host concurrency isn't enabled globally, concurrency instructions must be ignored. Regards, Gerrit. PS: You're on the wrong list. --Fig2xvG2VGoz8o/s Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff Index: src/tcpsvd.c =================================================================== RCS file: /var/lib/cvs/ipsvd/src/tcpsvd.c,v retrieving revision 1.21 diff -u -r1.21 tcpsvd.c --- src/tcpsvd.c 13 Feb 2004 13:19:01 -0000 1.21 +++ src/tcpsvd.c 7 Jul 2004 11:16:09 -0000 @@ -172,7 +172,7 @@ } else ac =IPSVD_DEFAULT; - if (phcc > 0) { + if (phcc && phccmax) { if (phcc > phccmax) { ac =IPSVD_DENY; if (phccmsg) { --Fig2xvG2VGoz8o/s--