Re: runsv and process groups

[Gerrit Pape <pape@smarden.org>]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On Thu, Aug 26, 2004 at 09:06:54PM -0400, Charlie Brady wrote:
> On Thu, 26 Aug 2004, Gerrit Pape wrote:
> > Hm, I'm not sure yet.  What do you think about runsvdir running runsv in
> > a new process group, and not runsv the run script?
> 
> That'd satisfy my concern, which is that a buggy run script or daemon can
> easily take down the whole system. That's certainly not the resiliency
> which people are looking for when they use supervise/runit. Or at least, 
> which I'm looking for.
> 
> I have more than an academic interest in this issue, since I've been 
> bitten by it in the past.

Here's a patch to runsvdir that adds a -P option to run each runsv
process in a new session and process group.  You need to change
/etc/runit/2 or /sbin/runsvdir-start to enable it.

Regards, Gerrit.

[-- Attachment #2: diff1 --]
[-- Type: text/plain, Size: 1258 bytes --]

Index: src/runsvdir.c
===================================================================
RCS file: /var/lib/cvs/runit/src/runsvdir.c,v
retrieving revision 1.15
diff -u -r1.15 runsvdir.c
--- src/runsvdir.c	2 Aug 2004 14:02:46 -0000	1.15
+++ src/runsvdir.c	11 Sep 2004 09:26:26 -0000
@@ -16,7 +16,7 @@
 #include "sig.h"
 #include "ndelay.h"
 
-#define USAGE " dir"
+#define USAGE " [-P] dir"
 #define VERSION "$Id: runsvdir.c,v 1.15 2004/08/02 14:03:08 pape Exp $"
 
 #define MAXSERVICES 1000
@@ -39,6 +39,7 @@
 iopause_fd io[1];
 struct taia stamplog;
 int exitsoon =0;
+int pgrp =0;
 
 void usage () { strerr_die4x(1, "usage: ", progname, USAGE, "\n"); }
 void fatal(char *m1, char *m2) {
@@ -72,6 +73,7 @@
 	warn("unable to set filedescriptor for log service", 0);
     sig_uncatch(sig_hangup);
     sig_uncatch(sig_term);
+    if (pgrp) setsid();
     pathexec_run(*prog, prog, (const char* const*)environ);
     fatal("unable to start runsv ", name);
   }
@@ -174,6 +176,13 @@
 
   progname =*argv++;
   if (! argv || ! *argv) usage();
+  if (**argv == '-') {
+    switch (*(*argv +1)) {
+    case 'P': pgrp =1;
+    case '-': ++argv;
+    }
+    if (! argv || ! *argv) usage();
+  }
 
   sig_catch(sig_term, s_term);
   sig_catch(sig_hangup, s_hangup);