Re: Trying to alter runit a little.

["L. Jason Godsey" <lannygodsey@yahoo.com>]

build# diff -u runit.c.original runit.c
--- runit.c.original    Fri Nov 18 10:56:29 2005
+++ runit.c     Fri Nov 18 10:57:41 2005
@@ -54,7 +54,7 @@
   int ttyfd;
   struct stat s;

-  if (getpid() != 1) strerr_die2x(111, FATAL, "must be run as process
no 1.");
+  //if (getpid() != 1) strerr_die2x(111, FATAL, "must be run as
process no 1.");
   setsid();

   sig_block(sig_alarm);

build# pwd
/usr/ports/sysutils/runit/work/admin/runit-1.3.1/src

build# make check
./check-local chpst runit runit-init runsv runsvchdir runsvctrl
runsvdir runsvstat sv  svlogd svwaitdown svwaitup utmpset
Checking chpst...
Checking runit...
Killed

main# echo $?
137

#### Original
build# cp runit.c.original runit.c
./check-local chpst runit runit-init runsv runsvchdir runsvctrl
runsvdir runsvstat sv  svlogd svwaitdown svwaitup utmpset
Checking chpst...
Checking runit...
Checking runit-init...
Checking runsv...
Checking runsvchdir...
Checking runsvctrl...
Checking runsvdir...
...

Something in Checking runit is making my FreeBSD 6 system have a stroke
if I remove the line:
if (getpid() != 1) strerr_die2x(111, FATAL, "must be run as process no
1.");


--- Gerrit Pape <pape@smarden.org> wrote:

> On Sat, Nov 12, 2005 at 07:02:24AM -0800, L. Jason Godsey wrote:
> > I've removed the requirment for runit to be pid 1.  I want to
> replace
> > init within a FreeBSD jail.  The first process to run isn't pid 1.
> > 
> > Do you see any problems that will become of this?
> 
> The runit-init program, normally installed as /sbin/init sends
> signals
> to pid 1 when told to reboot or halt the system.  The runit program
> doesn't provide any other communication channel than signals
> (combined
> with magic files), so it relies on being the process with id 1.  If
> you
> change that, nothing else should break but this IPC, but you then
> have
> the problem to find out the id of the runit process on shutdown. 
> Tools
> like pidof are exactly what runit replaces with a reliable solution.
> 
> > I just did a make package outside of the jail and the system froze,
> I'm
> > guessing the build process checks for error if runit is not pid 1.
> > 
> > The machine locked up and I'll have to wait a few hours for someone
> to
> > go to the colo machine and power cycle it for me.
> 
> I can't see how this relates to your change, building the package
> should
> never make the system hang, unless the system is buggy.
> 
> Regards, Gerrit.
>