From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/912
Path: news.gmane.org!not-for-mail
From: Gerrit Pape <pape@smarden.org>
Newsgroups: gmane.comp.sysutils.supervision.general
Subject: Re: Trying to alter runit a little.
Date: Mon, 21 Nov 2005 08:56:33 +0000
Message-ID: <20051121085059.2355.qmail@5ce7ed8b897c6a.315fe32.mid.smarden.org>
References: <20051117085412.28856.qmail@61a53ad4699a19.315fe32.mid.smarden.org> <20051118110704.67248.qmail@web33306.mail.mud.yahoo.com>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1132563199 20459 80.91.229.2 (21 Nov 2005 08:53:19 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 21 Nov 2005 08:53:19 +0000 (UTC)
Original-X-From: supervision-return-1148-gcsg-supervision=m.gmane.org@list.skarnet.org Mon Nov 21 09:53:12 2005
Return-path: <supervision-return-1148-gcsg-supervision=m.gmane.org@list.skarnet.org>
Original-Received: from antah.skarnet.org ([212.85.147.14])
	by ciao.gmane.org with smtp (Exim 4.43)
	id 1Ee7PQ-0006br-Ht
	for gcsg-supervision@gmane.org; Mon, 21 Nov 2005 09:52:20 +0100
Original-Received: (qmail 17385 invoked by uid 76); 21 Nov 2005 08:52:40 -0000
Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm
List-Post: <mailto:supervision@list.skarnet.org>
List-Help: <mailto:supervision-help@list.skarnet.org>
List-Unsubscribe: <mailto:supervision-unsubscribe@list.skarnet.org>
List-Subscribe: <mailto:supervision-subscribe@list.skarnet.org>
List-Archive: <http://www.skarnet.org/lists/>
Original-Received: (qmail 17367 invoked from network); 21 Nov 2005 08:50:59 -0000
Original-To: supervision@list.skarnet.org
Mail-Followup-To: supervision@list.skarnet.org
Content-Disposition: inline
In-Reply-To: <20051118110704.67248.qmail@web33306.mail.mud.yahoo.com>
Xref: news.gmane.org gmane.comp.sysutils.supervision.general:912
Archived-At: <http://permalink.gmane.org/gmane.comp.sysutils.supervision.general/912>

On Fri, Nov 18, 2005 at 03:07:04AM -0800, L. Jason Godsey wrote:
> build# diff -u runit.c.original runit.c
> --- runit.c.original    Fri Nov 18 10:56:29 2005
> +++ runit.c     Fri Nov 18 10:57:41 2005
> @@ -54,7 +54,7 @@
>    int ttyfd;
>    struct stat s;
> 
> -  if (getpid() != 1) strerr_die2x(111, FATAL, "must be run as process
> no 1.");
> +  //if (getpid() != 1) strerr_die2x(111, FATAL, "must be run as
> process no 1.");
>    setsid();
> 
>    sig_block(sig_alarm);
> 
> build# pwd
> /usr/ports/sysutils/runit/work/admin/runit-1.3.1/src
> 
> build# make check
> ./check-local chpst runit runit-init runsv runsvchdir runsvctrl
> runsvdir runsvstat sv  svlogd svwaitdown svwaitup utmpset
> Checking chpst...
> Checking runit...
> Killed
> 
> main# echo $?
> 137

Ah yes.  The runit program test actually is kind of a pseudo test.  It
just tests that the runit program can't be run unless it has pid 1.  So
if you make this change you need to skip or adapt the runit program
test, e.g.:

--- src/Makefile        23 Jul 2005 13:12:39 -0000      1.29
+++ src/Makefile        21 Nov 2005 08:49:52 -0000
@@ -3,8 +3,10 @@
 
 default: sysdeps $(IT)
 
-check: $(IT)
-       ./check-local $(IT)
+check: chpst runit-init runsv runsvchdir runsvctrl runsvdir runsvstat sv \
+         svlogd svwaitdown svwaitup utmpset
+       ./check-local chpst runit-init runsv runsvchdir runsvctrl runsvdir \
+         runsvstat sv svlogd svwaitdown svwaitup utmpset
 
 runit: load runit.o unix.a byte.a
        ./load runit unix.a byte.a -static

Regards, Gerrit.