From: Gerrit Pape <pape@smarden.org>
Subject: Re: timeout chpst -L
Date: Tue, 14 Feb 2006 10:36:25 +0000 [thread overview]
Message-ID: <20060214103625.4267.qmail@65cebaedea5163.315fe32.mid.smarden.org> (raw)
In-Reply-To: <20060214102323.GL6585@home.power>
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
On Tue, Feb 14, 2006 at 12:23:23PM +0200, Alex Efros wrote:
> On Tue, Feb 14, 2006 at 08:45:09AM +0000, Gerrit Pape wrote:
> > Yes, it's a race, the patch below should help. Thanks, Gerrit.
>
> Thanks, patch works. But I've found another bug, sorry. Now '-n' option
> don't work:
Yes, it's the same race, different impact. Can you try this slightly
extended patch?
Thanks, Gerrit.
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 959 bytes --]
Index: src/tryto.c
===================================================================
RCS file: /var/lib/cvs/socklog/src/tryto.c,v
retrieving revision 1.8
diff -u -r1.8 tryto.c
--- src/tryto.c 6 Feb 2005 11:36:50 -0000 1.8
+++ src/tryto.c 14 Feb 2006 10:33:59 -0000
@@ -104,6 +104,7 @@
taia_now(&now);
taia_uint(&deadline, timeout);
taia_add(&deadline, &now, &deadline);
+ timeout =0;
for (;;) {
int iopausefds;
@@ -163,15 +164,15 @@
int i;
char *s;
- if (wait_nohang(&rc) == pid) break;
- taia_now(&now);
- if ((timeout =taia_less(&deadline, &now))) break;
-
sig_unblock(sig_child);
iopause(x, iopausefds, &deadline, &now);
sig_block(sig_child);
while (read(selfpipe[0], &ch, 1) == 1) {}
+
+ if (wait_nohang(&rc) == pid) break;
+ taia_now(&now);
+ if ((timeout =taia_less(&deadline, &now))) break;
r = buffer_feed(&buffer_x);
if (r < 0) {
next prev parent reply other threads:[~2006-02-14 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 16:30 Alex Efros
2006-02-13 20:18 ` Alex Efros
2006-02-14 8:45 ` Gerrit Pape
2006-02-14 10:23 ` Alex Efros
2006-02-14 10:36 ` Gerrit Pape [this message]
2006-02-14 11:01 ` Alex Efros
2006-02-14 11:21 ` Gerrit Pape
2006-02-14 11:30 ` Alex Efros
2006-02-14 11:36 ` Gerrit Pape
2006-02-14 11:54 ` Alex Efros
2006-02-14 12:39 ` Gerrit Pape
2006-02-14 12:53 ` Alex Efros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214103625.4267.qmail@65cebaedea5163.315fe32.mid.smarden.org \
--to=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).