Re: runit not collecting zombies

[Gerrit Pape <pape@smarden.org>]

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On Sat, May 26, 2007 at 01:35:17PM +0300, Alex Efros wrote:
> On Fri, May 25, 2007 at 01:07:42AM +0200, Radek Podgorny wrote:
> > I'm experiancing a weird behaviour where runit (1.5.0) does not collect 
> > zombies. AFAIK the init (pid=1) process should take care of these and 
> > make them quit "correctly". I know that when zombies show up, the 
> > initiating application is to blame but in the real world, I need a 
> > stable server where I don't run out of PIDs after just few hours :-(.
> 
> I've just got same issue. This is first time I see runit does not collect
> zombies. Server uptime is 28 days, runit 1.5.0 (upgraded from 1.4.1 at
> 21 Apr). Server generate huge amount of short-living processes, so maybe
> some integer overflow in runit or something similar result in this issue.
> 
> Right now I've 8114 zombies and user which run all these scripts now
> unable to start new processes:
>     bash: fork: Resource temporarily unavailable
> 
> Looks like I've to reboot to fix this issue for some time. :-(

Hi Alex, the runit program didn't change from 1.4.1 to 1.5.0 or 1.5.1,
so downgrading should not help.  I'm not yet completely sure what the
actual problem is, but have an idea.  Can you please test the patch
below?:

 cd /package/admin/runit
 patch -p0 </the/attached/diff
 package/install
 ln /sbin/runit /sbin/runit.old
 install -m0755 command/runit /sbin/runit
 reboot

Thanks, Gerrit.

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 628 bytes --]

Index: src/runit.c
===================================================================
RCS file: /cvs/runit/src/runit.c,v
retrieving revision 1.14
diff -u -r1.14 runit.c
--- src/runit.c	21 Nov 2006 15:09:18 -0000	1.14
+++ src/runit.c	3 Jun 2007 10:59:19 -0000
@@ -157,8 +157,9 @@
       sig_block(sig_child);
       sig_block(sig_int);
       
-      read(selfpipe[0], &ch, 1);
-      child =wait_nohang(&wstat);
+      while (read(selfpipe[0], &ch, 1) == 1) {}
+      while ((child =wait_nohang(&wstat)) > 0)
+        if (child == pid) break;
 
       /* reget stderr */
       if ((ttyfd =open_write("/dev/console")) != -1) {