Re: Please review my Bluetooth run script

[Laurent Bercot <ska-supervision@skarnet.org>]

> What I want to know is if this is the "proper" way to go about it. The
> original Blue-Z startup script starts quite a few daemons all at once,
> and it kills off each of them with a "killall".

 The original point of service supervision, what caused it to be
implemented (with daemontools first, then with runit) in the first place,
is that some daemons need to be automatically restarted if something
somehow causes them to die.

 Your current "run script" does not accomplish this.
 It starts the various Bluetooth daemons, and kills them, just like a
System V script would do. Those daemons are not supervised; what is
supervised is actually the following script:

   exec sh -c "while [ 1 ]; do sleep 100; done"

 I'm sure you will agree that supervising this script isn't particularly
useful. :)

 In other words, you've successfully converted your System V scripts
to the runsv model, but you're not taking advantage of what service
supervision can do for you. As is, you'd still be better off using a
start/stop SysV script, and do without your akward "bluetooth" service
which isn't a real service.

 My advice would be to have separate services for hcid, sdpd, hidd,
rfcommm (if it's a long-lived daemon), dund, pand and pppd. All those
daemons need to be kept alive and running; as an additional benefit,
you don't have to lose their logs by sending them to /dev/null, you
can make use of runsv's logging facility to send each daemon's log
into its own multilog or whatever your favorite logging system is.

 Then, once you have set up one service for each Bluetooth daemon
that needs to be up, you can have a "bluetooth start" script that
does a "sv up" on all those services at once, and a "bluetooth stop"
script that does a "sv down" on them. And you can even control
each daemon separately if the need arises.

-- 
 Laurent