From: Laurent Bercot <ska-supervision@skarnet.org>
To: supervision@list.skarnet.org
Subject: Re: s6-log taking 100% CPU
Date: Thu, 13 Dec 2012 15:09:44 +0100 [thread overview]
Message-ID: <20121213140944.GA546@skarnet.org> (raw)
In-Reply-To: <20121213141924.GA16171@hape.internal>
> I have noticed that s6-log enters busyloop after failing to rotate
> the log. Some data:
>
> * I don't have strace output at hand, but from memory it was
> infinite stream of identical poll() related lines.
> * s6-log runs as: s6-log -b s16777215 n25 S0 !xz -0q /var/service/nslcd/log
> * Happens only for service loggers missing the log/state file. Most
> service loggers do not have the log/state file, this is probably
> my mistake in some deployment script.
Good catch : you discovered two bugs at once ! They are clearly my
mistake, not yours.
* s6-log should not fail to execute a processor when the state file is
missing: it should do as if there was an empty state file.
* if the processor execution fails for some reason, s6-log should not
busyloop: it should use the cooldown timer defined by the "r" directive.
Thanks for the report, I will work on a fix and prepare a new release.
--
Laurent
next prev parent reply other threads:[~2012-12-13 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 14:19 Vallo Kallaste
2012-12-13 14:09 ` Laurent Bercot [this message]
2012-12-14 5:31 ` Laurent Bercot
2012-12-14 5:37 ` Laurent Bercot
2012-12-13 14:36 ` Vallo Kallaste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213140944.GA546@skarnet.org \
--to=ska-supervision@skarnet.org \
--cc=supervision@list.skarnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).