From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/2939 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Arsen Newsgroups: gmane.comp.sysutils.supervision.general Subject: [PATCH] runit.c: add sys/select.h include Date: Wed, 8 Apr 2020 16:12:17 +0200 Message-ID: <20200408141216.14120-1-arsen@managarm.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108870"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Arsen To: supervision@list.skarnet.org Original-X-From: supervision-return-2528-gcsg-supervision=m.gmane-mx.org@list.skarnet.org Wed Apr 08 16:14:59 2020 Return-path: Envelope-to: gcsg-supervision@m.gmane-mx.org Original-Received: from alyss.skarnet.org ([95.142.172.232]) by ciao.gmane.io with smtp (Exim 4.92) (envelope-from ) id 1jMBTm-000S7c-Iv for gcsg-supervision@m.gmane-mx.org; Wed, 08 Apr 2020 16:14:58 +0200 Original-Received: (qmail 5181 invoked by uid 89); 8 Apr 2020 14:15:21 -0000 Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm Original-Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Original-Received: (qmail 5174 invoked from network); 8 Apr 2020 14:15:20 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=managarm.org; s=2020; t=1586355292; bh=Qi/Tuy/uJ0CFKBuknrtagPHvyk9oTi3W3iojFejRt1g=; h=From:To:Cc:Subject:Date:From; b=s4KwnhfQYsr0nFoOh6OySLP61UFp8UHphfHiXYXOa35JtSiSG5x1QNoedYDMydE85 1w8q63BBIBMOnTx5XPoyoP3vgNB4lgkCrHwWf8Lvfy/1SsLRA1AlqMTV+pt6y8vKr/ F1f+IEt58Qmcd0a96F4GrqzkHMKRPB8d+W+anm0pSin7aAFNCProvxbu32uPrRbfFK x5FDskaTjSwGQBSUKSIol3f9AI+43n7smJwaAnfwZAF6KgMEZwKi/3+L8TYrgwj/gr c4P3HNBDtqvt2HFku+Mrg2ezO2SCXrlT7S7jY0itCKJcJCg1uPvyR6rgZkRgjqdqRq rkrw/hkJiouqg== X-Mailer: git-send-email 2.24.1 Xref: news.gmane.io gmane.comp.sysutils.supervision.general:2939 Archived-At: runit.c seems to rely on a transitive dependency between sys/types.h and sys/select.h that exists on some systems such as Linux. When we tried porting runit to managarm we ran into an issue related to it, where fd_set and timeval weren't declared at time of use in runit.c. Consulting the Open Group's POSIX specification, it shows that sys/types.h does not need to specify either of the two, and that they are in sys/select.h. This patch corrects the include. --- src/runit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/runit.c b/src/runit.c index 48620b3..976495b 100644 --- a/src/runit.c +++ b/src/runit.c @@ -2,6 +2,7 @@ #include #include #include +#include #include #include #include -- 2.24.1