From: Tomas Carnecky <tom@dbservice.com>
To: Charlie Brady <charlieb-supervision@budge.apana.org.au>
Cc: supervision@list.skarnet.org
Subject: Re: runit: buffer_feed()
Date: Fri, 23 Jan 2009 15:57:09 +0100 [thread overview]
Message-ID: <4979DAC5.8090007@dbservice.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0901230929090.22160@e-smith.charlieb.ott.istop.com>
On 01/23/2009 03:30 PM, Charlie Brady wrote:
>
> On Fri, 23 Jan 2009, Tomas Carnecky wrote:
>
>> I'm looking at the buffer_feed() function in runit and I can't make
>> sense of it. I'm in the process of replacing all byte_* functions with
>> standard memcpy/memcmp etc,
>
> Why?
byte_copy is a poor reimplementation of memcpy, and memcpy is part of
any libc runtime (according to the man page, conforming to: SVr4,
4.3BSD, C89, C99, POSIX.1-2001.). Please point my to a single libc that
implements malloc, open, write, fork but not memcpy.
Also, it makes the executable smaller and faster, the project as a whole
faster to compile, the code easier to read etc.
But nvm, I found out what I was missing. The code still doesn't make
sense to me, but at least the resulting executables works correctly.
tom
next prev parent reply other threads:[~2009-01-23 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 13:06 Tomas Carnecky
2009-01-23 14:30 ` Charlie Brady
2009-01-23 14:57 ` Tomas Carnecky [this message]
2009-01-23 17:06 ` Laurent Bercot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4979DAC5.8090007@dbservice.com \
--to=tom@dbservice.com \
--cc=charlieb-supervision@budge.apana.org.au \
--cc=supervision@list.skarnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).