From: Earl Chew <earl_chew@agilent.com>
To: supervision@list.skarnet.org
Subject: sv sometimes won't issue down request
Date: Sun, 19 Jul 2009 07:52:17 -0700 [thread overview]
Message-ID: <4A633321.1060207@agilent.com> (raw)
In-Reply-To: <loom.20090717T090207-38@post.gmane.org>
This defect was submitted against the busybox/runit implementation:
https://bugs.busybox.net/show_bug.cgi?id=461
> touch /tmp/testservice/down
> runsv /tmp/testservice &
> sv once /tmp/testservice
> sv down /tmp/testservice
>
> The last line attempts to bring down the service, but does nothing.
Denys Vlasenko wrote:
> I propose just removing this test:
>
> if (svstatus.want == *a)
> return 0;
>
>
> it seems to be an optimization (and buggy one at that).
There is similar code in runit 2.0.0:
> int control(char *a) {
> if (svstatus_get() <= 0) return(-1);
> if (svstatus[17] == *a) return(0);
> if ((fd =open_write("supervise/control")) == -1) {
Earl
next prev parent reply other threads:[~2009-07-19 14:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 8:00 Bug for sv status in lsb mode Mathieu Poumeyrol
2009-07-13 13:42 ` Charlie Brady
2009-07-13 14:13 ` Mathieu Poumeyrol
2009-07-13 14:18 ` Mathieu Poumeyrol
2009-07-13 14:20 ` Charlie Brady
2009-07-17 9:08 ` Gerrit Pape
2009-07-17 10:02 ` Mathieu Poumeyrol
2009-07-17 11:08 ` Gerrit Pape
2009-07-19 14:52 ` Earl Chew [this message]
2009-07-19 17:14 ` svwaitup races with sv Earl Chew
2009-07-24 20:31 ` Charlie Brady
2009-07-24 20:35 ` Earl Chew
2009-07-24 20:18 ` sv sometimes won't issue down request (specifically, after 'sv once xxx') Charlie Brady
2009-07-24 20:38 ` Earl Chew
2009-07-24 21:01 ` Charlie Brady
2009-07-25 19:49 ` Joan Picanyol i Puig
2009-07-27 9:09 ` sv sometimes won't issue down request Gerrit Pape
2009-07-27 17:39 ` Earl Chew
2010-05-31 19:54 ` Bug for sv status in lsb mode Erik Wright
2010-06-03 9:04 ` Gerrit Pape
2010-06-03 14:12 ` Erik Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A633321.1060207@agilent.com \
--to=earl_chew@agilent.com \
--cc=supervision@list.skarnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).