From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/1966
Path: news.gmane.org!not-for-mail
From: Earl Chew <earl_chew@agilent.com>
Newsgroups: gmane.comp.sysutils.supervision.general
Subject: sv sometimes won't issue down request
Date: Sun, 19 Jul 2009 07:52:17 -0700
Message-ID: <4A633321.1060207@agilent.com>
References: <8F9355C5-C168-4AD7-8B6C-502416E7EECC@zoy.org> <Pine.LNX.4.64.0907130942001.359@e-smith.charlieb.ott.istop.com> <94175859-2733-4ACF-85E9-DD5FF627F23B@zoy.org> <17A739BC-94BA-4611-A523-6978934F0D61@zoy.org> <loom.20090717T090207-38@post.gmane.org>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1248015180 16910 80.91.229.12 (19 Jul 2009 14:53:00 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 19 Jul 2009 14:53:00 +0000 (UTC)
To: supervision@list.skarnet.org
Original-X-From: supervision-return-2201-gcsg-supervision=m.gmane.org@list.skarnet.org Sun Jul 19 16:52:53 2009
Return-path: <supervision-return-2201-gcsg-supervision=m.gmane.org@list.skarnet.org>
Envelope-to: gcsg-supervision@gmane.org
Original-Received: from antah.skarnet.org ([212.85.147.14])
	by lo.gmane.org with smtp (Exim 4.50)
	id 1MSXky-000409-Di
	for gcsg-supervision@gmane.org; Sun, 19 Jul 2009 16:52:52 +0200
Original-Received: (qmail 23869 invoked by uid 76); 19 Jul 2009 14:54:06 -0000
Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm
List-Post: <mailto:supervision@list.skarnet.org>
List-Help: <mailto:supervision-help@list.skarnet.org>
List-Unsubscribe: <mailto:supervision-unsubscribe@list.skarnet.org>
List-Subscribe: <mailto:supervision-subscribe@list.skarnet.org>
List-Archive: <http://www.skarnet.org/lists/>
Original-Received: (qmail 23855 invoked from network); 19 Jul 2009 14:54:06 -0000
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
In-Reply-To: <loom.20090717T090207-38@post.gmane.org>
X-OriginalArrivalTime: 19 Jul 2009 14:56:09.0703 (UTC) FILETIME=[0D190F70:01CA0881]
X-Scanned-By: MPP/Clamd http://www.messagepartners.com
X-Scanned-By: MPP invoked on aglcosbs04
Xref: news.gmane.org gmane.comp.sysutils.supervision.general:1966
Archived-At: <http://permalink.gmane.org/gmane.comp.sysutils.supervision.general/1966>

This defect was submitted against the busybox/runit implementation:

https://bugs.busybox.net/show_bug.cgi?id=461

> touch /tmp/testservice/down
> runsv /tmp/testservice &
> sv once /tmp/testservice
> sv down /tmp/testservice
> 
> The last line attempts to bring down the service, but does nothing.

Denys Vlasenko wrote:

> I propose just removing this test:
> 
>         if (svstatus.want == *a)
>                 return 0;
> 
> 
> it seems to be an optimization (and buggy one at that).


There is similar code in runit 2.0.0:

> int control(char *a) {
>   if (svstatus_get() <= 0) return(-1);
>   if (svstatus[17] == *a) return(0);
>   if ((fd =open_write("supervise/control")) == -1) {

Earl