Re: sv sometimes won't issue down request

[Earl Chew <earl_chew@agilent.com>]

Gerrit Pape wrote:
>> Denys Vlasenko wrote:
>>
>>> I propose just removing this test:
>>>
>>>         if (svstatus.want == *a)
>>>                 return 0;

Gerrit,

My original proposed patch (for the BusyBox implementation) was:

+	if (svstatus.want == *a) {
+		if (*a != 'd' || ! svstatus.pid_le32)
+			return 0;
+	}

which is very similar to your proposed patch:

>    if (svstatus_get() <= 0) return(-1);
> -  if (svstatus[17] == *a) return(0);
> +  if (svstatus[17] == *a)
> +    if (*a != 'd' || svstatus[18] == 1) return(0);


Is it preferred to test for svstatus[18] rather than checking for an
active PID ?


Are you saying that we're better of checking for this "special case"
rather than removing the optimisation in its entirety?


Earl