From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19203 invoked from network); 11 Dec 2022 17:53:39 -0000 Received: from alyss.skarnet.org (95.142.172.232) by inbox.vuxu.org with ESMTPUTF8; 11 Dec 2022 17:53:39 -0000 Received: (qmail 23026 invoked by uid 89); 11 Dec 2022 17:54:01 -0000 Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Received: (qmail 23017 invoked from network); 11 Dec 2022 17:54:00 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F5zyznDXUtRWRr2P0bJLowR4ALqLnHmQNpSaYthS9D4=; b=8KcA5k8U7lokJbfU8cL/FIX+N8XoyCph5NsQRaERaYFNV9KWLMsefWjIwxHyLbX+he 8FsHjdi8Ak+Z9y5HZ9Bqv3vC/O8FeYMu0yHglli0HNtECiCIgq6zZlw+0LF20KhwTOH4 c5d0PwAwOeZrbPa8psTCFfyWinSyva+pHxxIcSbBEddWnFn/jivKxQxLsRli5UlYqP70 QYCPBgwTp7kWZ7R5n5CqF/A3XGVUFXSLEhUKEjV9k1YDyz3/C3h5X8R8Ab2ZVGZuJrh+ qF7krzNn1W8e8Gg/0/1zNeqdA/z+5KF+VeLbMjqqV7CxwwsGeMFPNj+tKCRvMGVwKp1W XDyQ== X-Gm-Message-State: ANoB5pkO8jRPfLTeGltESa/YTs2+Pwh69QMRkFB8wOU7rBv+5hWqSSxT BtEp65R9QQtA6eVY+uZ1tMzhKeTFD0o= X-Google-Smtp-Source: AA0mqf5tmQfFD1IUPxPMSh3j6sSpwaFVAPT20eJ8BRSaxFdaiFAgdHxAG2J8Zg2myJxg8Tx21RUZ1A== X-Received: by 2002:a05:600c:21c1:b0:3cf:8833:1841 with SMTP id x1-20020a05600c21c100b003cf88331841mr10599595wmj.39.1670781212734; Sun, 11 Dec 2022 09:53:32 -0800 (PST) From: Leah Neukirchen To: supervision@list.skarnet.org Subject: [PATCH] chpst: fix parsing of negative values in -n Date: Sun, 11 Dec 2022 18:53:31 +0100 Message-ID: <875yehrfms.fsf@vuxu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain I noticed chpst -n didn't work and found this fix. I just patched it in Void, other distros may want to apply this too. Fix UB which breaks -n with negative nice values. Ensure optarg is incremented strictly before it is read from. --- runit-2.1.2/src/chpst.c.orig +++ runit-2.1.2/src/chpst.c @@ -308,7 +308,7 @@ case 'n': switch (*optarg) { case '-': - if (optarg[scan_ulong(++optarg, &ul)]) usage(); nicelvl =ul; + ++optarg; if (optarg[scan_ulong(optarg, &ul)]) usage(); nicelvl =ul; nicelvl *=-1; break; case '+': ++optarg; -- Leah Neukirchen https://leahneukirchen.org/