supervision - discussion about system services, daemon supervision, init, runlevel management, and tools such as s6 and runit
 help / color / mirror / Atom feed
From: Mathieu Poumeyrol <kali@zoy.org>
To: supervision@list.skarnet.org
Subject: Bug for sv status in lsb mode
Date: Mon, 13 Jul 2009 10:00:58 +0200	[thread overview]
Message-ID: <8F9355C5-C168-4AD7-8B6C-502416E7EECC@zoy.org> (raw)

Hello there,

I have tracked down a bug in the lsb-compatible code for sv status:   
sv return 0 even if the service is down.

The variable r in the "status" function in the sv.c file is global,  
and altered in the curse of the function, making the last test  
useless. From what I have seen, saving the status in a local variable  
instead of using the global r solve the issue, but I don't know if  
this fix is without side-effect.

I hope somebody can fix this in a proper way and push the changes.

Thanks !


             reply	other threads:[~2009-07-13  8:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13  8:00 Mathieu Poumeyrol [this message]
2009-07-13 13:42 ` Charlie Brady
2009-07-13 14:13   ` Mathieu Poumeyrol
2009-07-13 14:18     ` Mathieu Poumeyrol
2009-07-13 14:20       ` Charlie Brady
2009-07-17  9:08       ` Gerrit Pape
2009-07-17 10:02         ` Mathieu Poumeyrol
2009-07-17 11:08           ` Gerrit Pape
2009-07-19 14:52         ` sv sometimes won't issue down request Earl Chew
2009-07-19 17:14           ` svwaitup races with sv Earl Chew
2009-07-24 20:31             ` Charlie Brady
2009-07-24 20:35               ` Earl Chew
2009-07-24 20:18           ` sv sometimes won't issue down request (specifically, after 'sv once xxx') Charlie Brady
2009-07-24 20:38             ` Earl Chew
2009-07-24 21:01               ` Charlie Brady
2009-07-25 19:49                 ` Joan Picanyol i Puig
2009-07-27  9:09           ` sv sometimes won't issue down request Gerrit Pape
2009-07-27 17:39             ` Earl Chew
2010-05-31 19:54         ` Bug for sv status in lsb mode Erik Wright
2010-06-03  9:04           ` Gerrit Pape
2010-06-03 14:12             ` Erik Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8F9355C5-C168-4AD7-8B6C-502416E7EECC@zoy.org \
    --to=kali@zoy.org \
    --cc=supervision@list.skarnet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).