* Bug in gpape's ipsvd
@ 2004-07-04 18:08 Torne
2004-07-08 18:05 ` Gerrit Pape
0 siblings, 1 reply; 2+ messages in thread
From: Torne @ 2004-07-04 18:08 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
tcpsvd interprets an instruction of 'C0' for a particular host as meaning
'no connections', whereas the documentation states that this should allow
unlimited connections up to the global limit. This situation only arises
when there is a global per-host concurrency limit which is being overridden
for particular IPs. Patch below.
--- tcpsvd.c.orig 2004-07-04 19:00:56.000000000 +0100
+++ tcpsvd.c 2004-07-04 19:01:15.000000000 +0100
@@ -172,7 +172,7 @@
}
else ac =IPSVD_DEFAULT;
- if (phcc > 0) {
+ if (phccmax > 0) {
if (phcc > phccmax) {
ac =IPSVD_DENY;
if (phccmsg) {
--
Torne (torne@wolfpuppy.org.uk)
Wolf puppy, coder and social engineer.
[-- Attachment #2: Type: application/pgp-signature, Size: 187 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug in gpape's ipsvd
2004-07-04 18:08 Bug in gpape's ipsvd Torne
@ 2004-07-08 18:05 ` Gerrit Pape
0 siblings, 0 replies; 2+ messages in thread
From: Gerrit Pape @ 2004-07-08 18:05 UTC (permalink / raw)
Cc: supervision
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Sun, Jul 04, 2004 at 07:08:44PM +0100, Torne wrote:
> tcpsvd interprets an instruction of 'C0' for a particular host as meaning
> 'no connections', whereas the documentation states that this should allow
> unlimited connections up to the global limit. This situation only arises
> when there is a global per-host concurrency limit which is being overridden
> for particular IPs. Patch below.
Yes, thanks a lot for pointing this out. See below for a slightly
updated patch; if per host concurrency isn't enabled globally,
concurrency instructions must be ignored.
Regards, Gerrit.
PS: You're on the wrong list.
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 444 bytes --]
Index: src/tcpsvd.c
===================================================================
RCS file: /var/lib/cvs/ipsvd/src/tcpsvd.c,v
retrieving revision 1.21
diff -u -r1.21 tcpsvd.c
--- src/tcpsvd.c 13 Feb 2004 13:19:01 -0000 1.21
+++ src/tcpsvd.c 7 Jul 2004 11:16:09 -0000
@@ -172,7 +172,7 @@
}
else ac =IPSVD_DEFAULT;
- if (phcc > 0) {
+ if (phcc && phccmax) {
if (phcc > phccmax) {
ac =IPSVD_DENY;
if (phccmsg) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-08 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-04 18:08 Bug in gpape's ipsvd Torne
2004-07-08 18:05 ` Gerrit Pape
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).