From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/2352 Path: news.gmane.org!.POSTED!not-for-mail From: Guillermo Newsgroups: gmane.comp.sysutils.supervision.general Subject: Re: G++ warnings for set-control-group-knob from nosh-1.37 Date: Sun, 11 Mar 2018 23:33:00 -0300 Message-ID: References: <27dc6882-1c58-e64e-afd4-d08c6b13f8ee@NTLWorld.COM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1520821877 17381 195.159.176.226 (12 Mar 2018 02:31:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Mar 2018 02:31:17 +0000 (UTC) To: supervision@list.skarnet.org Original-X-From: supervision-return-1943-gcsg-supervision=m.gmane.org@list.skarnet.org Mon Mar 12 03:31:13 2018 Return-path: Envelope-to: gcsg-supervision@m.gmane.org Original-Received: from alyss.skarnet.org ([95.142.172.232]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1evDF0-0004LO-6W for gcsg-supervision@m.gmane.org; Mon, 12 Mar 2018 03:31:10 +0100 Original-Received: (qmail 3265 invoked by uid 89); 12 Mar 2018 02:33:30 -0000 Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm Original-Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 3258 invoked from network); 12 Mar 2018 02:33:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=U4EkEdDQfN7KyswRDqJ9t+ZHzCgcAMBw21NB6LnIXpc=; b=UH2j6FNeki+G285FLukZgReJqK/ejBpDdowwta76Rr981rSo9Nh41tV0dG20jDe/07 HoOL+4ZaxntjJ6kilNs761jXUsiB10JLdb19NxeI8fHBef9JlTjGHbAd9BMZCxYp/603 R63bt12HYuEqHOiH0lhmpTF1b7be5dXoEmfFWMef+VGqd5fMAOqvm2nT5unPseKkXCJE nzhd1ayjtdkNVKTfQsL86n20HO/rqCqdRKfpghCqrQi/GtScztdGPtI4C6ivNRFLItGN icBkDCjfL2qK/vGjCVW5ONFfepp6XEoUeBC3RCg2+AocIE/TghjodRHJUEWmuLCify7p Jvxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=U4EkEdDQfN7KyswRDqJ9t+ZHzCgcAMBw21NB6LnIXpc=; b=SFSPOukdmoDvlJ3b0dZFv/YRnChQdbVLtVug51QOnxWLY15+NljEP0xojFFvh7DucW vmiADYJyMlppy5UuHirZZ5AH8AXFdoXYx0IZ/K2UNW37EeH6FKaATsuffMEP8iAvEzdu B3oR6YzbwfyE4B0gsoOpFiq1QKHgXRRVl6WgW2Vjw8Q/uF6lEcrQOIlImt9kSAIBtfMh XVSZZ+wMPf0iOaCmMmgP7FhiYyRPvKHSS02q8zkImx1hcPFIWfFcZSM4K+ArUco6nbGe qcdGb56wFVZAJyi6/yUbJjruZHtBR4PBkRbt/IG7E7MT+mZugr2T/WFDRDE0ljuG1p4Q wuCw== X-Gm-Message-State: AElRT7Egs2jWS8PcoPURQd2LZOK2fvub+exrDiZswBdo4OyIOM/p2PlM h8UCC7VKN2VpVWr3j0sv5BGksVmuoI9+wwufbqY= X-Google-Smtp-Source: AG47ELvzCJUZHd0WNQ6PmaWTZdPJOqvebWTFUWenst+8Iq6zB2xULLFWN5yhRFksWYudeooKvIIw2NwZ+KtY631wUpQ= X-Received: by 10.36.236.130 with SMTP id g124mr7183527ith.68.1520821981269; Sun, 11 Mar 2018 19:33:01 -0700 (PDT) In-Reply-To: <27dc6882-1c58-e64e-afd4-d08c6b13f8ee@NTLWorld.COM> Xref: news.gmane.org gmane.comp.sysutils.supervision.general:2352 Archived-At: 2018-03-11 20:57 GMT-03:00 Jonathan de Boyne Pollard: > > The macro generates no warning in the GNU C library in Debian 9, but I > should have caught that overload that was not passing by reference. It is > fixed now, thank you. The in-development source archive for 1.38 is in the > usual place. Yes, both G++ warnings are gone now. BTW, the removal of the macros from has already been committed, so it looks like it is going to happen for GNU libc version 2.28: * https://sourceware.org/git/?p=glibc.git;a=commit;h=e16deca62e16f645213dffd4ecd1153c37765f17 However, a new warning has appeared: In file included from set-control-group-knob.cpp:23:0: popt.h:85:16: warning: 'virtual bool popt::table_definition::execute(popt::processor&, char, const char*)' was hidden [-Woverloaded-virtual] virtual bool execute(processor &, char c, const char * s); ^~~~~~~ popt.h:100:16: warning: by 'popt::top_table_definition::execute' [-Woverloaded-virtual] virtual bool execute(processor &, const char * s); ^~~~~~~ I believe this is because the 1.38 development version dropped a 'using table_definition::execute;' declaration from the definition of class popt::top_table_definition that was present in 1.37, so the three parameter version of popt::table_definition::execute() would now be hidden. I only did a quick 'redo set-control-group-knob.o' test, so I'm not sure if it is important or if it affects anything, though. Thanks, G.