From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30704 invoked from network); 17 Nov 2020 20:06:18 -0000 Received: from alyss.skarnet.org (95.142.172.232) by inbox.vuxu.org with ESMTPUTF8; 17 Nov 2020 20:06:18 -0000 Received: (qmail 14430 invoked by uid 89); 17 Nov 2020 20:06:42 -0000 Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Received: (qmail 14423 invoked from network); 17 Nov 2020 20:06:42 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=3SMuSXfO8RZdeN9yKI9CZxsohvs8tWi3P60Ag4fNS0g=; b=oLQij8wPQz24Znn42mcYaNHqn+o9bEBKZXFSc54GRCgCmTTVVK6HDNXPAQAho0/4U5 D1HU3wt4oldjZwQciH4RdIRvmeoDSu7C/f4x6YcRA4/2sX0GG0vYxdK/gTbp4cEczdKJ Kv9yXt33LKdK3KaRugMTSfcnOKY+tzU4t8pxzqO1Z7Q1XZFLyRDsUCWWiok0ASnPN+iu /SQh6qGk3fL/vSDCRdQiXfnGXZeN56sNUCl63tn6GKvBHJMfq69pbgtY0V9TqZnp6Boc B2ulwSHyFTemDugiQ0cAxbCJuf5M+B9pPvtWKL/vrzZX6KoRBx/kDjUSMKvYNkL0oRXL 11FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3SMuSXfO8RZdeN9yKI9CZxsohvs8tWi3P60Ag4fNS0g=; b=ZGWDC8/kTrOLalcLehfFeusPFUuOcYSQSkmFH+AsLTzcbuOUvieXD6E3494kip9y+v PwU3zNP7i9MqV1Sj/mc1fpnvW0qx70nPPhYfh39Jka8dJW3HmO+j4yGh2igXc8MD6nBq mSmeMts4PaAVUTdAZcNUAm9mKXhMeJMB8xCAIyrUWv+WFJ9HwUfgsK33v/iWMW1zwemR fbHzBiK37Y1RgaL3zaqFQQpj3UxxxY5Qt9HNdF8MCj6dYuIU1EN90lTeVIoOkzg6VBHT O3TZJGTeFTIXnNjUdi55FBPSM4N09EUj/fRTgWWX1DQkjM6kcPhHQXTp7vGpX6WuVXTL Ue5w== X-Gm-Message-State: AOAM532TxzE498eDzPeGofbc9zF7tqE8Km4Yvwd3YpZx9ctxh5wvT7cA zYKcQgYK4HHrXfBGRh8oM3Tuvh0H6b7JRaK8VFR4Bw3h6SE= X-Google-Smtp-Source: ABdhPJyBchPBkjUfT84iHf0WuwaeMjU6SPlHCM2x3j2ETFgXa9eJQ0HSIDB7RMRIuCP5eZl6TrslzAuxPm2qgHbxc0A= X-Received: by 2002:a2e:9046:: with SMTP id n6mr2701644ljg.22.1605643574717; Tue, 17 Nov 2020 12:06:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Xavier Stonestreet Date: Tue, 17 Nov 2020 21:06:03 +0100 Message-ID: Subject: Re: s6-permafailon not acting as expected To: supervision@list.skarnet.org Content-Type: text/plain; charset="UTF-8" Upon further investigation, it turns out my events filter is incorrect, because exit codes greater than 128 imply that the service has been killed by a signal (128 + signal number), so the exit code range 1-255 actually means exit codes 1 to 127 or any signal. The correct specification for my example is 1-127,SIGBUS,SIGSEGV. I believe a call to sigemptyset() in s6-permafailon.c may still be warranted however, because the POSIX spec states the results of sigismember() are otherwise undefined. On Tue, Nov 17, 2020 at 7:43 PM Xavier Stonestreet wrote: > > Hold on, I've now encountered the same issue for another service, but > with signals :) > > In servicedir's finish: > s6-permafailon 120 2 1-255,SIGBUS,SIGSEGV exit 0 > > svc -t servicedir > svc -t servicedir > > 2020-11-17 19:20:24.465424531 s6-permafailon: info: PERMANENT FAILURE > triggered after 2 events involving signal 15 in the last 120 seconds > > s6-svdt servicedir | s6-tai64nlocal > 2020-11-17 19:19:30.449842687 signal SIGTERM > 2020-11-17 19:20:24.419594225 signal SIGTERM > > Back to s6-permafailon.c: the sigset_t sigs is not initialized > either... Looks like it needs a call to sigemptyset(). > > Hope this helps :)