supervision - discussion about system services, daemon supervision, init, runlevel management, and tools such as s6 and runit
 help / color / mirror / Atom feed
From: Xavier Stonestreet <xstonestreet@gmail.com>
To: supervision@list.skarnet.org
Subject: s6-permafailon not acting as expected
Date: Mon, 16 Nov 2020 19:01:18 +0100	[thread overview]
Message-ID: <CAK-rGMK2z048US4iPyunwZ5z=1B-HinoemKdJ38MkBkkGHvMsg@mail.gmail.com> (raw)

Hello,

I'm seeing unexpected results with s6-permafailon.
I have this line in my finish script:

s6-permafailon 120 2 1-255,SIGBUS,SIGSEGV exit 0

If I kill the service twice in a row with s6-svc -t, s6-permafailon
triggers a permanent failure with the message:

s6-permafailon: info: PERMANENT FAILURE triggered after 2 events
involving exit code 0 in the last 120 seconds.

The service did die with exit code 0, but s6-permafail is wrong, since
exit code 0 is not specified in the filter.

s6-svdt reports:
2020-11-16 16:00:17.451308493 exitcode 0
2020-11-16 16:00:28.495276767 exitcode 0

Looking at the source code in s6-permafailon.c, it seems to me that
the codes[32] bitarray is not initialized with zeroes before calling
bitarray_set(n). But not being intimately familiar with the code I'm
probably looking at it incorrectly. And I'm not instrumented nor
knowledgeable enough to run a debugger.

Could you shed some light on this unexpected behavior and tell me what
I'm doing wrong, as the case may be.

Great supervision and service management toolbox by the way - I love it! :)

Thanks,
X.

s6 2.9.2.0
skalibs 2.9.3.0
execline 2.6.1.1
built from source, linked with musl libc on Linux

             reply	other threads:[~2020-11-16 18:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16 18:01 Xavier Stonestreet [this message]
2020-11-16 22:05 ` Laurent Bercot
2020-11-17 15:32   ` Xavier Stonestreet
2020-11-17 18:43     ` Xavier Stonestreet
2020-11-17 20:06       ` Xavier Stonestreet
2020-11-17 21:42       ` Laurent Bercot
2020-11-18 17:22         ` Xavier Stonestreet
2020-11-18 18:35           ` Laurent Bercot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK-rGMK2z048US4iPyunwZ5z=1B-HinoemKdJ38MkBkkGHvMsg@mail.gmail.com' \
    --to=xstonestreet@gmail.com \
    --cc=supervision@list.skarnet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).