From: Dmitry Bogatov <KAction@debian.org>
To: supervision@list.skarnet.org, 916230-quiet@bugs.debian.org
Subject: Re: Log rotation issue with runit
Date: Thu, 27 Dec 2018 09:36:28 +0000 [thread overview]
Message-ID: <E1gcS5d-0001SF-81@eggs.gnu.org> (raw)
In-Reply-To: <20181226015822.GH29946@home.lan>
[2018-12-26 03:58] Alex Efros <powerman@powerman.name>
> Hi!
>
> I'm not sure is it good idea to include .u files in usual rotation process
> at all, and especially handle them just like .s files. If several crashes
> happens for some reason in a short period of time this will result in
> deletion of all log files except last (say) 10 .u files, which are usually
> small and may contain just one line. Replacing 10MB of last logs with 10
> last log lines doesn't sounds like a nice idea.
>
> Possible "right" solution will be to keep same amount of last .u files as
> configured for .s files, i.e. if we've configured to keep last 10 files
> then we may have at most double amount (10 .u files and 10 .s files).
> (I didn't checked mentioned patches, so maybe they already works this way.)
Why would it be wrong to just keep appending to `current' instead of
moving it to `.u' file? (see my patch at end of bug thread)
And this issue happens not only on crash, it happens after every
termination of svlogd, due any signal. I would agree that SIGKILL is
crash, but issue reproduces with SIGINT and SIGTERM.
next prev parent reply other threads:[~2018-12-27 9:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 13:39 Dmitry Bogatov
2018-12-25 14:57 ` Alex Efros
2018-12-25 18:17 ` Guillermo
2018-12-25 18:30 ` Guillermo
2018-12-26 1:58 ` Alex Efros
2018-12-27 9:36 ` Dmitry Bogatov [this message]
2018-12-27 11:41 ` Laurent Bercot
2018-12-28 6:47 ` Jonathan de Boyne Pollard
2018-12-27 13:47 ` Steve Litt
2018-12-28 1:27 ` Guillermo
2018-12-27 23:39 ` Guillermo
2018-12-29 18:33 ` Dmitry Bogatov
2018-12-29 22:32 ` Guillermo
2018-12-28 6:57 ` Jonathan de Boyne Pollard
2018-12-26 5:05 ` Steve Litt
2018-12-27 9:36 ` Dmitry Bogatov
2018-12-27 13:07 ` Steve Litt
2018-12-29 18:33 ` Dmitry Bogatov
2018-12-30 1:20 ` Steve Litt
2018-12-30 10:04 ` Jonathan de Boyne Pollard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1gcS5d-0001SF-81@eggs.gnu.org \
--to=kaction@debian.org \
--cc=916230-quiet@bugs.debian.org \
--cc=supervision@list.skarnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).