From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/1969
Path: news.gmane.org!not-for-mail
From: Charlie Brady <charlieb-supervision@budge.apana.org.au>
Newsgroups: gmane.comp.sysutils.supervision.general
Subject: Re: sv sometimes won't issue down request (specifically, after 'sv
 once xxx')
Date: Fri, 24 Jul 2009 16:18:16 -0400 (EDT)
Message-ID: <Pine.LNX.4.64.0907241558211.18966@e-smith.charlieb.ott.istop.com>
References: <8F9355C5-C168-4AD7-8B6C-502416E7EECC@zoy.org>
 <Pine.LNX.4.64.0907130942001.359@e-smith.charlieb.ott.istop.com>
 <94175859-2733-4ACF-85E9-DD5FF627F23B@zoy.org> <17A739BC-94BA-4611-A523-6978934F0D61@zoy.org>
 <loom.20090717T090207-38@post.gmane.org> <4A633321.1060207@agilent.com>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Trace: ger.gmane.org 1248466713 1119 80.91.229.12 (24 Jul 2009 20:18:33 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 24 Jul 2009 20:18:33 +0000 (UTC)
Cc: supervision@list.skarnet.org
To: Earl Chew <earl_chew@agilent.com>
Original-X-From: supervision-return-2204-gcsg-supervision=m.gmane.org@list.skarnet.org Fri Jul 24 22:18:26 2009
Return-path: <supervision-return-2204-gcsg-supervision=m.gmane.org@list.skarnet.org>
Envelope-to: gcsg-supervision@gmane.org
Original-Received: from antah.skarnet.org ([212.85.147.14])
	by lo.gmane.org with smtp (Exim 4.50)
	id 1MURDi-0003HQ-SD
	for gcsg-supervision@gmane.org; Fri, 24 Jul 2009 22:18:22 +0200
Original-Received: (qmail 28077 invoked by uid 76); 24 Jul 2009 20:19:37 -0000
Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm
List-Post: <mailto:supervision@list.skarnet.org>
List-Help: <mailto:supervision-help@list.skarnet.org>
List-Unsubscribe: <mailto:supervision-unsubscribe@list.skarnet.org>
List-Subscribe: <mailto:supervision-subscribe@list.skarnet.org>
List-Archive: <http://www.skarnet.org/lists/>
Original-Received: (qmail 28067 invoked from network); 24 Jul 2009 20:19:37 -0000
X-X-Sender: charlieb@e-smith.charlieb.ott.istop.com
In-Reply-To: <4A633321.1060207@agilent.com>
Xref: news.gmane.org gmane.comp.sysutils.supervision.general:1969
Archived-At: <http://permalink.gmane.org/gmane.comp.sysutils.supervision.general/1969>


On Sun, 19 Jul 2009, Earl Chew wrote:

> This defect was submitted against the busybox/runit implementation:
>
> https://bugs.busybox.net/show_bug.cgi?id=461
>
>>  touch /tmp/testservice/down
>>  runsv /tmp/testservice &
>>  sv once /tmp/testservice
>>  sv down /tmp/testservice
>>
>>  The last line attempts to bring down the service, but does nothing.
>
> Denys Vlasenko wrote:
>
>>  I propose just removing this test:
>>
>>          if (svstatus.want == *a)
>>                  return 0;
>>
>>  it seems to be an optimization (and buggy one at that).

Yes it does seem buggy optimisation.

Note that if you simply removed that check, you would change not only the 
'once' behaviour of sv/runsv, but also the behaviour when multiple 'sv d 
xxx' calls are made on a running service. If the optimisation is not 
re-implemented in runsv, then there will be multiple signals and/or custom 
control scripts run where previously there was only one.