From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/376
Path: main.gmane.org!not-for-mail
From: "Clemens Fischer" <ino-qc@spotteswoode.de.eu.org>
Newsgroups: gmane.comp.sysutils.supervision.general
Subject: Re: svlogd: segfault
Date: 29 Mar 2004 03:11:09 +0200
Message-ID: <ad20pid8.fsf@ID-23066.news.dfncis.de>
References: <20040324144830.GA8950@home.power>
	<20040324221137.27555.qmail@3475a0130f1610.315fe32.mid.smarden.org>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1080522684 12046 80.91.224.253 (29 Mar 2004 01:11:24 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 29 Mar 2004 01:11:24 +0000 (UTC)
Original-X-From: supervision-return-614-gcsg-supervision=m.gmane.org@list.skarnet.org Mon Mar 29 03:11:16 2004
Return-path: <supervision-return-614-gcsg-supervision=m.gmane.org@list.skarnet.org>
Original-Received: from antah.skarnet.org ([212.43.221.114])
	by deer.gmane.org with smtp (Exim 3.35 #1 (Debian))
	id 1B7lJ6-0005jw-00
	for <gcsg-supervision@gmane.org>; Mon, 29 Mar 2004 03:11:16 +0200
Original-Received: (qmail 2064 invoked by uid 76); 29 Mar 2004 01:11:33 -0000
Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm
List-Post: <mailto:supervision@list.skarnet.org>
List-Help: <mailto:supervision-help@list.skarnet.org>
List-Unsubscribe: <mailto:supervision-unsubscribe@list.skarnet.org>
List-Subscribe: <mailto:supervision-subscribe@list.skarnet.org>
List-Archive: <http://www.skarnet.org/lists/>
Original-Received: (qmail 2058 invoked from network); 29 Mar 2004 01:11:33 -0000
Mail-Followup-To: supervision@list.skarnet.org
Original-To: supervision@list.skarnet.org
In-Reply-To: <20040324221137.27555.qmail@3475a0130f1610.315fe32.mid.smarden.org> (Gerrit
 Pape's message of "Wed, 24 Mar 2004 22:11:16 +0000")
User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (berkeley-unix)
Xref: main.gmane.org gmane.comp.sysutils.supervision.general:376
X-Report-Spam: http://spam.gmane.org/gmane.comp.sysutils.supervision.general:376

* 2004-03-24 Gerrit Pape:

> diff -u -r1.11 svlogd.c
> --- src/svlogd.c	19 Jan 2004 12:20:03 -0000	1.11
> +++ src/svlogd.c	24 Mar 2004 22:07:06 -0000
> @@ -349,7 +349,7 @@
>      unsigned long port;
>  
>      if (verbose) strerr_warn4(INFO, "read: ", ld->name, "/config", 0);
> -    for (i =0; i < sa.len -1; ++i) {
> +    for (i =0; i +1 < sa.len; ++i) {
>        if ((len =byte_chr(&sa.s[i], sa.len -i, '\n')) == 1) {
>       	++i; continue;
>        }

sorry, i just cannot see the semantic difference between the while clauses
"i < sa.len -1" and "i +1 < sa.len".  what's the deal here?

  clemens