From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/2749 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jonathan de Boyne Pollard Newsgroups: gmane.comp.sysutils.supervision.general Subject: Re: runit patches to fix compiler warnings on RHEL 7 Date: Wed, 4 Dec 2019 11:13:41 +0000 Message-ID: References: <20191125214342.y7lx5mixrljr6s27@gromit.local> <20191127203307.ohaameqfgncm52h5@gromit.local> <20191202171333.ja7zvo6clpr2ogkr@gromit.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38141"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 To: supervision@list.skarnet.org Original-X-From: supervision-return-2338-gcsg-supervision=m.gmane.org@list.skarnet.org Wed Dec 04 12:13:45 2019 Return-path: Envelope-to: gcsg-supervision@m.gmane.org Original-Received: from alyss.skarnet.org ([95.142.172.232]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1icSbJ-0009lW-5o for gcsg-supervision@m.gmane.org; Wed, 04 Dec 2019 12:13:45 +0100 Original-Received: (qmail 4683 invoked by uid 89); 4 Dec 2019 11:14:09 -0000 Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm Original-Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Original-Received: (qmail 4676 invoked from network); 4 Dec 2019 11:14:09 -0000 X-Originating-IP: [86.10.101.211] X-Authenticated-User: J.deBoynePollard-newsgroups@NTLWorld.COM X-Spam: 0 X-Authority: v=2.3 cv=f85m+t6M c=1 sm=1 tr=0 a=FQ5CjUvp3JFI4KFGyeqcZw==:117 a=FQ5CjUvp3JFI4KFGyeqcZw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=rg2V61WcAAAA:8 a=k4fvmSudeNHPxWKd7tUA:9 a=QEXdDO2ut3YA:10 a=h2Zpg1Gm_F5nnxfnuFwt:22 a=pHzHmUro8NiASowvMSCR:22 a=xoEH_sTeL_Rfw54TyV31:22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com; s=meg.feb2017; t=1575458022; bh=LV5ZsM8mUmRwFoTYVU/Pg4saHc6mG4mdhiGXTKU6sAg=; h=Subject:To:References:From:Date:In-Reply-To; b=AcN2dDlfE/Pja3iW7lnaRGjMO5pfRqM4mPZKwgv5vTHi/jE/+Gj/1/rm5rN7+xkKR rovw2WUBfa52+2ZzDynx4881/S3IcBcmvKYqqIB2HGm3lUba02TeJaTT8YJF3SSaBT SYVJRw8XqbeP7DNk/EbF62PiiVl1rt0bfY7oeKqDtCuAKdc0+ODfAR44yW/Usf+Vuc DRb8dqnpajUzQ9JKJ1LYuWeSg7joAEKFx7bZ/Sn/124GIhSvd64EUVJGzbn8UFk/F/ R03kkJG9hpUPvaHe8T+1ZDTH51RP5y4nYTQb/jCWGUaG1anV2bKwHdK9HNzZOJn4Ob GAYGIFj3oPDXQ== In-Reply-To: <20191202171333.ja7zvo6clpr2ogkr@gromit.local> X-CMAE-Envelope: MS4wfNoFjYruV5kVeCwLygJGz9fuCUHz0nDDgN5Kuvo7bgvcYA329jvIlVzUPTnVaM2HZvTPOtrKzib0CQjBHnFLQ3d2mGrf+uRQoaMy6isup03WBrZjyA21 +b2Nnww4HGLExC+ij3s1IXlzB5sk8cIc5xdI1uIhDBQG2U9PBtJ2xa9+5NI3PWbZaBP8TohYrR0X9FYxtnIkZK+7OwT3it9hhlcQmdM8rhTIOUQd4IiQy2P0 Xref: news.gmane.org gmane.comp.sysutils.supervision.general:2749 Archived-At: Some of those are common. I looked at similar stuff in daemontools, where runit got some of this code from, when I packaged it up with some of the other Bernstein softwares some years ago. However, you have missed the point of HASSHORTSETGROUPS. There's no point in having conditionally compiled code selected by it that uses gid_t in both codepaths. If you are going to use gid_t, you do not need the HASSHORTSETGROUPS mechanism in its entirety. Think about what it does. * http://jdebp.uk./Softwares/djbwares/ In the nosh toolset, I have no such mechanisms. The code uses the types, with a std::vector for the call to setgroups() in setuidgid-fromenv for example. The only similar mechanism picks between the very old waitpid() function and the newer (but still old, because it was SVR4) waitid() function. And only OpenBSD ever needs the code to use the former, in practice.