From: "Laurent Bercot" <ska-supervision@skarnet.org>
To: "Xavier Stonestreet" <xstonestreet@gmail.com>,
supervision@list.skarnet.org
Subject: Re: s6-permafailon not acting as expected
Date: Mon, 16 Nov 2020 22:05:26 +0000 [thread overview]
Message-ID: <em70b375f4-b630-403c-80b7-c755fe00f4ba@elzian> (raw)
In-Reply-To: <CAK-rGMK2z048US4iPyunwZ5z=1B-HinoemKdJ38MkBkkGHvMsg@mail.gmail.com>
>The service did die with exit code 0, but s6-permafail is wrong, since
>exit code 0 is not specified in the filter.
>
>Looking at the source code in s6-permafailon.c, it seems to me that
>the codes[32] bitarray is not initialized with zeroes before calling
>bitarray_set(n).
You're probably right that it is the issue! (codes was a static
variable in the first iteration; static variables do not need to be
0-initialized. But then I reworked the code, made codes an automatic
variable, and failed to initialize it to zero. And that is why relying
on magic features is a bad thing, and I should stop doing this out of
laziness.)
I fixed it in the latest git of s6; if you prefer numbered releases,
I'm working on a bigger release (with some interface changes and a
major version bump) that should happen before the end of the year, but
not right now ^^'
Please try the fixed version. If you don't want to use the git head,
you can apply the very simple diff:
https://git.skarnet.org/cgi-bin/cgit.cgi/s6/diff/src/supervision/s6-permafailon.c
If that version doesn't solve your problem, then I'll investigate
further.
Thanks for the report!
--
Laurent
next prev parent reply other threads:[~2020-11-16 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 18:01 Xavier Stonestreet
2020-11-16 22:05 ` Laurent Bercot [this message]
2020-11-17 15:32 ` Xavier Stonestreet
2020-11-17 18:43 ` Xavier Stonestreet
2020-11-17 20:06 ` Xavier Stonestreet
2020-11-17 21:42 ` Laurent Bercot
2020-11-18 17:22 ` Xavier Stonestreet
2020-11-18 18:35 ` Laurent Bercot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=em70b375f4-b630-403c-80b7-c755fe00f4ba@elzian \
--to=ska-supervision@skarnet.org \
--cc=supervision@list.skarnet.org \
--cc=xstonestreet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).