Re: Help with chpst -e

[Robin Bowes <robin-lists@robinbowes.com>]

Andras Korn wrote:
> This is more "Debianish" in that it gets the configuration from
> /etc/default/svlogd, possibly overridden by /etc/default/name-of-service.
> These files can override the svlogd config as well (e.g. set a different
> postprocessor or retention policy).

That's an idea. I may incorporate that (I'm using RH-flavours).

> I keep /var/log/sv on a separate volume from /var/log because not everything
> logs via svlogd and /var/log might be filled.

OK.

> As for your script, some comments:
> 
>> # Get the service name
>> logdir=`pwd`
>> svcdir=${logdir%/log}
>> SERVICE_NAME=${svcdir##*/}
> 
> Isn't this a bashism?

Yes. I welcome suggestions how to do this in a more portable way.

>> # Set LOGUSER and LOGDIR to default values if not set in ./env
>> : ${LOGUSER:=${LOG_PARENT}/${SERVICE_NAME}}
>> : ${LOGDIR:=${LOG_PARENT}/${SERVICE_NAME}}
> 
> You could use LOGDIR=${LOGDIR:-$LOG_PARENT/$SERVICE_NAME} for no real
> benefit.

Yes, indeed.

> Setting LOGUSER to the name of a directory is probably a
> copy-paste mistake, I guess? :)

No, it's based on the premise that each service is run by a user with 
the same name. This is over-ridden by the contents of ./env/LOGUSER

>> # Make sure the log dir exists
>> if [ ! -e "${LOGDIR}" ]; then
>>   mkdir -p "${LOGDIR}"
>> fi
> 
> This fails if LOGDIR exists but is not a directory. (Of course, that
> shouldn't happen.)

True. I could use -d, but then do I test for $LOGDIR existing but not 
being a directory? One has to stop somewhere...!

>> # Set ownership & permissions on the log dir
>> chown -R ${LOGUSER} "${LOGDIR}"
> 
> This gives ownership of the config file, if it exists, to svlogd. I don't
> think that's good. 

No, it gives ownership of the logdir to the user running the log process 
so it can write to that dir.

R.