Re: Help with chpst -e

[Robin Bowes <robin-lists@robinbowes.com>]

Andras Korn wrote:
> How about
> 
> SERVICE_NAME=$(basename $(dirname $(readlink -f .)))
> 
> Of course, I don't know how portable readlink is.

I seem to remember reading that readlink is OS-dependent, but it's 
shell-agnostic.

>>> Setting LOGUSER to the name of a directory is probably a
>>> copy-paste mistake, I guess? :)
>> No, it's based on the premise that each service is run by a user with the 
>> same name. This is over-ridden by the contents of ./env/LOGUSER
> 
> Wow. I never considered using usernames with slashes in them, but of course,
> why not?

*blush* - sorry, you were right. It was a mistake. It should of course be:

# Set LOGUSER and LOGDIR to default values if not set in ./env
: ${LOGUSER:=${SERVICE_NAME}}
: ${LOGDIR:=${LOG_PARENT}/${SERVICE_NAME}}


>>>> # Make sure the log dir exists
>>>> if [ ! -e "${LOGDIR}" ]; then
>>>>   mkdir -p "${LOGDIR}"
>>>> fi
>>> This fails if LOGDIR exists but is not a directory. (Of course, that
>>> shouldn't happen.)
>> True. I could use -d, but then do I test for $LOGDIR existing but not being 
>> a directory? One has to stop somewhere...!
> 
> You're right, but at least "cd $LOGDIR || exit 1" fails in a predictable
> way. :)

Yeah, I'll give that some more thought.

>>>> # Set ownership & permissions on the log dir
>>>> chown -R ${LOGUSER} "${LOGDIR}"
>>> This gives ownership of the config file, if it exists, to svlogd. I don't
>>> think that's good. 
>> No, it gives ownership of the logdir to the user running the log process so 
>> it can write to that dir.
> 
> chown -R is recursive, meaning that it will chown the svlogd 'config' file
> which resides in the logdir to the user svlogd will run as.
> 
> I agree this only has theoretical significance.

Again, you're correct; I forgot about the config file - I've only just 
started using runit (vs. daemontools).

I don't think it's a major issue, but could be fixed by:

chown root "${LOGDIR}"/config

R.