skalibs build failure

skalibs build failure

[Lorenzo Beretta]

Undeclared variable in selfpipe_trap.c and selfpipe_untrap.c:

script -c ./package/install ; cat typescript
==>
Script started on Thu 30 Jun 2011 09:41:08 PM CEST
Linking ./src into ./compile...

Importing ./conf-compile files into the build tree...
(Remove the compile/ subdirectory if conf-compile/ has been modified
since the last build.)

Linking include files...

Making subsystem systype...
make: Nothing to be done for `it'.
Subsystem systype done.

Making subsystem sys...
make: Nothing to be done for `it'.
Subsystem sys done.

Making subsystem sysdeps...
make: Nothing to be done for `it'.
Subsystem sysdeps done.

Making subsystem headers...
make: Nothing to be done for `it'.
Subsystem headers done.

Making subsystem libstddjb...
./gen-Makefile > Makefile.real && make -f Makefile.real && : > .done
make[1]: Entering directory 
`/usr/local/package/prog/skalibs-1.0.0/compile/libstddjb'
exec ./compile selfpipe_trap.c
selfpipe_trap.c: In function ‘selfpipe_trap’:
selfpipe_trap.c:44:17: error: ‘i’ undeclared (first use in this function)
selfpipe_trap.c:44:17: note: each undeclared identifier is reported only 
once for each function it appears in
make[1]: *** [selfpipe_trap.o] Error 1
make[1]: Leaving directory 
`/usr/local/package/prog/skalibs-1.0.0/compile/libstddjb'
make: *** [.done] Error 2

Script done on Thu 30 Jun 2011 09:41:09 PM CEST



PS

Sorry for not providing a patch, but I'm not (yet) comfortable enough 
with signals to write one. And thank you for the libs!

Re: skalibs build failure

[Laurent Bercot]

> selfpipe_trap.c: In function ???selfpipe_trap???:
> selfpipe_trap.c:44:17: error: ???i??? undeclared (first use in this 
> function)

 Thanks for the report. Fix on the way.
 For bug-reports on skarnet.org software that is not s6, please
use the skaware@list.skarnet.org mailing-list instead.

-- 
 Laurent

genalloc

[Vincent de RIBOU]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]



Hi,

After having append many items, I didn't find any API in genalloc to remove an item and then collapse all.

Did I miss something??
Should I implement it with byte_copy??

Thanks.
Vincent

Re: genalloc

[Laurent Bercot]

 Please use the skaware@list.skarnet.org list for questions about my
software that are not related to s6 or general supervision things.
 Mail-Followup-To set.


> After having append many items, I didn't find any API in genalloc to remove an item and then collapse all.
> 
> Did I miss something??
> Should I implement it with byte_copy??

 Generally speaking, what you are asking for (to delete a cell in a
genalloc and shift all the following cells to the left) requires a lot
of memory rewriting and is not needed: there's always a way to avoid
shifting.

 Say you have a genalloc g of type T and you want to delete cell number i.

 If you don't care about the order of your cells, just replace the ith
cell with the last one:
  unsigned int n = genalloc_len(T, g) ;
  genalloc_s(T, g)[i] = genalloc_s(T, g)[n-1] ;
  genalloc_setlen(T, g, n-1) ;

 If you care about the order of your cells, a simple genalloc isn't the
best structure. You could use a linked list structure, using the genalloc
for storage purposes only: expand type T with an unsigned int that is
the index of your "next" cell in the genalloc, make 0 the head of your list,
and there you go. No rewriting needed.

 If you really want to shift cells in a genalloc, then yes, I guess you
could implement it with byte_copy(). But it will be suboptimal in all
cases.

-- 
 Laurent