supervision - discussion about system services, daemon supervision, init, runlevel management, and tools such as s6 and runit
 help / color / mirror / Atom feed
From: Gerrit Pape <pape@smarden.org>
To: supervision@list.skarnet.org
Subject: Re: Possible bug in various runit programs
Date: Fri, 26 Sep 2008 08:43:33 +0000 (UTC)	[thread overview]
Message-ID: <loom.20080926T084115-444@post.gmane.org> (raw)
In-Reply-To: <48CACF00.7070204@facebook.com>

David Reiss <dreiss <at> facebook.com> writes:
> 2008-09-12_11:12:09.67178 chpst: fatal: unable to open current working
directory: no error
> I tracked it down to these lines in chpst:
>   if (! (wdir =open_read(".")))
>     fatal("unable to open current working directory");
> The problem is that open returns -1 on failure, not 0, which is a valid
> file descriptor (I was closing stdin when spawning runsvdir).
> Grepping runit for '! (.*open' (no quotes) revealed a lot of places where
> this same problem could be happening.

Yes, I confirm the bug, thanks a lot for spotting this error.

Regards, Gerrit.




      reply	other threads:[~2008-09-26  8:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12 20:20 David Reiss
2008-09-26  8:43 ` Gerrit Pape [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20080926T084115-444@post.gmane.org \
    --to=pape@smarden.org \
    --cc=supervision@list.skarnet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).