From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.comp.sysutils.supervision.general/1920
Path: news.gmane.org!not-for-mail
From: Gerrit Pape <pape@smarden.org>
Newsgroups: gmane.comp.sysutils.supervision.general
Subject: Re: Possible bug in various runit programs
Date: Fri, 26 Sep 2008 08:43:33 +0000 (UTC)
Message-ID: <loom.20080926T084115-444@post.gmane.org>
References: <48CACF00.7070204@facebook.com>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1222418635 22102 80.91.229.12 (26 Sep 2008 08:43:55 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 26 Sep 2008 08:43:55 +0000 (UTC)
To: supervision@list.skarnet.org
Original-X-From: supervision-return-2155-gcsg-supervision=m.gmane.org@list.skarnet.org Fri Sep 26 10:44:52 2008
connect(): Connection refused
Return-path: <supervision-return-2155-gcsg-supervision=m.gmane.org@list.skarnet.org>
Envelope-to: gcsg-supervision@gmane.org
Original-Received: from antah.skarnet.org ([212.85.147.14])
	by lo.gmane.org with smtp (Exim 4.50)
	id 1Kj8wT-0000yn-UF
	for gcsg-supervision@gmane.org; Fri, 26 Sep 2008 10:44:50 +0200
Original-Received: (qmail 23039 invoked by uid 76); 26 Sep 2008 08:44:06 -0000
Mailing-List: contact supervision-help@list.skarnet.org; run by ezmlm
List-Post: <mailto:supervision@list.skarnet.org>
List-Help: <mailto:supervision-help@list.skarnet.org>
List-Unsubscribe: <mailto:supervision-unsubscribe@list.skarnet.org>
List-Subscribe: <mailto:supervision-subscribe@list.skarnet.org>
List-Archive: <http://www.skarnet.org/lists/>
Original-Received: (qmail 23031 invoked from network); 26 Sep 2008 08:44:05 -0000
X-Injected-Via-Gmane: http://gmane.org/
Original-Lines: 15
Original-X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: main.gmane.org
User-Agent: Loom/3.14 (http://gmane.org/)
X-Loom-IP: 77.245.32.75 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.14eol) Gecko/20070505 (Debian-1.8.0.15~pre080323b-0etch2) Galeon/2.0.2 (Debian package 2.0.2-4))
Original-Sender: news <news@ger.gmane.org>
Xref: news.gmane.org gmane.comp.sysutils.supervision.general:1920
Archived-At: <http://permalink.gmane.org/gmane.comp.sysutils.supervision.general/1920>

David Reiss <dreiss <at> facebook.com> writes:
> 2008-09-12_11:12:09.67178 chpst: fatal: unable to open current working
directory: no error
> I tracked it down to these lines in chpst:
>   if (! (wdir =open_read(".")))
>     fatal("unable to open current working directory");
> The problem is that open returns -1 on failure, not 0, which is a valid
> file descriptor (I was closing stdin when spawning runsvdir).
> Grepping runit for '! (.*open' (no quotes) revealed a lot of places where
> this same problem could be happening.

Yes, I confirm the bug, thanks a lot for spotting this error.

Regards, Gerrit.