The Unix Heritage Society mailing list
 help / color / mirror / Atom feed
From: ron@ronnatalie.com (Ron Natalie)
Subject: [TUHS] Bugs in V6 'dcheck'
Date: Sat, 31 May 2014 12:18:06 -0400	[thread overview]
Message-ID: <006001cf7ceb$e81ac120$b8504360$@ronnatalie.com> (raw)
In-Reply-To: <20140531155527.39A3B18C09C@mercury.lcs.mit.edu>

>   OK, so I was wrong! The variable in question was a global static, 'ino'
(the current inode number),

Static is a much overloaded word in C, it's just a global variable.


> 'ino' was cleared before the _second_ pass, but not the _first_. So it was
zero for the first pass of the first disk, but non-zero for the first pass
on the second disk.

Yes, and in the version 7 version of icheck
(http://www.tuhs.org/Archive/PDP-11/Trees/V7/usr/src/cmd/dcheck.c) they
appear to have fixed it.
It is set to zero before both the pass1 and pass2 loops.

I'm pretty sure whoever added the feature to check more than one file system
at a time didn't test it very well in V6.   




  reply	other threads:[~2014-05-31 16:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 15:55 Noel Chiappa
2014-05-31 16:18 ` Ron Natalie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-03 17:33 Nelson H. F. Beebe
2014-06-02  3:34 Noel Chiappa
2014-06-02  4:05 ` Mary Ann Horton
2014-06-02  6:12 ` arnold
2014-06-03 12:11 ` emanuel stiebler
2014-06-02  3:18 Noel Chiappa
2014-06-02  2:14 Michael Spacefalcon
2014-06-02  2:51 ` John Cowan
2014-05-31 23:24 Doug McIlroy
2014-06-01  0:17 ` Kevin Schoedel
2014-06-01 22:54   ` scj
2014-06-01 23:48 ` A. P. Garcia
2014-06-02  1:11   ` Ronald Natalie
2014-06-02  2:10     ` A. P. Garcia
2014-06-03 16:38 ` Nelson H. F. Beebe
2014-05-31 14:19 Noel Chiappa
2014-05-31 13:30 Norman Wilson
2014-05-31 16:03 ` John Cowan
     [not found]   ` <20140531161620.GL28034@mcvoy.com>
2014-05-31 17:16     ` John Cowan
2014-05-31 13:15 Noel Chiappa
2014-05-31 13:23 ` Ronald Natalie
2014-05-31 18:58 ` Tim Newsham
2014-05-31 19:48 ` Clem Cole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006001cf7ceb$e81ac120$b8504360$@ronnatalie.com' \
    --to=ron@ronnatalie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).