From mboxrd@z Thu Jan  1 00:00:00 1970
From: ron@ronnatalie.com (Ron Natalie)
Date: Sat, 31 May 2014 12:18:06 -0400
Subject: [TUHS] Bugs in V6 'dcheck'
In-Reply-To: <20140531155527.39A3B18C09C@mercury.lcs.mit.edu>
References: <20140531155527.39A3B18C09C@mercury.lcs.mit.edu>
Message-ID: <006001cf7ceb$e81ac120$b8504360$@ronnatalie.com>

>   OK, so I was wrong! The variable in question was a global static, 'ino'
(the current inode number),

Static is a much overloaded word in C, it's just a global variable.


> 'ino' was cleared before the _second_ pass, but not the _first_. So it was
zero for the first pass of the first disk, but non-zero for the first pass
on the second disk.

Yes, and in the version 7 version of icheck
(http://www.tuhs.org/Archive/PDP-11/Trees/V7/usr/src/cmd/dcheck.c) they
appear to have fixed it.
It is set to zero before both the pass1 and pass2 loops.

I'm pretty sure whoever added the feature to check more than one file system
at a time didn't test it very well in V6.