From: lm@mcvoy.com (Larry McVoy)
Subject: [TUHS] early cc variable and function names
Date: Fri, 17 Oct 2014 13:42:29 -0700 [thread overview]
Message-ID: <20141017204229.GA4249@mcvoy.com> (raw)
In-Reply-To: <1413578228.125790.180311153.48CF1319@webmail.messagingengine.com>
On Fri, Oct 17, 2014 at 04:37:08PM -0400, random832 at fastmail.us wrote:
> On Thu, Oct 16, 2014, at 22:52, Larry McVoy wrote:
> > abc.st_size
> >
> > Huh, abc is a struct stat.
> >
> > I get that it was a bug and needed to be fixed but I wish that everyone
> > still pretended that it was one namespace, makes code so much easier to
> > read.
>
> I'm not sure what your design is that you're more than a screen away
> from either its declaration, a stat call, or the fact that it's got size
> _and_ mode _and_ mtime etc.
>
> And if you do that, why stop there? Why not require the type to be
> repeated to dereference any pointer?
Hey, everyone is welcome to their own opinion and it doesn't have to match
mine. I review a lot of code, a lot of code that I didn't write. Lots of
times the review is in a web browser that doesn't know how to tag to the
definition. Sure I can clone the repo and make tags and tag to it but for
small reviews there is no need.
I do a bunch of code reviews every day. foo.size is a lot less helpful
than foo.vfs_size or whatever.
Your mileage may vary, where I work we optimize for the reader not for
the writer. That's how it is when you work for me. When I work for
you then your rules win :)
--
---
Larry McVoy lm at mcvoy.com http://www.mcvoy.com/lm
next prev parent reply other threads:[~2014-10-17 20:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 2:29 Noel Chiappa
2014-10-17 2:40 ` John Cowan
2014-10-17 2:52 ` Larry McVoy
2014-10-17 3:46 ` John Cowan
2014-10-17 3:54 ` Larry McVoy
2014-10-17 19:41 ` Clem Cole
2014-10-17 20:37 ` random832
2014-10-17 20:42 ` Larry McVoy [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-18 10:32 Noel Chiappa
2014-10-18 23:03 ` Ron Natalie
2014-10-18 23:11 ` Dave Horsfall
2014-10-17 16:11 Noel Chiappa
2014-10-17 1:51 Mark Longridge
2014-10-17 2:20 ` Milo Velimirovic
2014-10-17 2:21 ` Dave Horsfall
2014-10-17 13:35 ` random832
2014-10-17 13:44 ` Warner Losh
2014-10-17 14:07 ` arnold
2014-10-17 14:22 ` Milo Velimirović
2014-10-17 19:29 ` random832
2014-10-18 7:25 ` Greg 'groggy' Lehey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017204229.GA4249@mcvoy.com \
--to=lm@mcvoy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).