From: Jon Steinhart <jon@fourwinds.com>
To: The Eunuchs Hysterical Society <tuhs@tuhs.org>
Subject: Re: [TUHS] Tech Sq elevator [ really type-checking ]
Date: Sun, 12 Jan 2020 16:01:02 -0800 [thread overview]
Message-ID: <202001130001.00D012bC608441@darkstar.fourwinds.com> (raw)
In-Reply-To: <20200112235051.GG9174@mcvoy.com>
Larry McVoy writes:
> On Sun, Jan 12, 2020 at 03:40:40PM -0800, Jon Steinhart wrote:
> > Linux contains several sets of list_for_each_entry() macros that are essentially
> > obfuscated for loops that generate inefficient code.
>
> Very common idiom in any real system. BitKeeper has them as well, they are
> used everywhere. They are too useful to not use. The BitKeeper ones give
> you most of Perl's list capabilities.
I don't see it. In the cases that I've seen so far in linux the only uses are
inserting, deleting, and traversing lists. My opinion that anyone who can't
write
for (p = list; p != NULL; p = p->next)
shouldn't be programming, much less in the kernel. To me, type-checking and
code clarity are vastly more important. If I want to program in Perl, I do
so. When I program in C that's what I do.
I do want to be clear that I'm coming at this from a code maintenance angle.
Code that I write for my personal use looks way different than what I write
professionally. I'm willing to put in more work up front to make sure that
other people can easily understand my code because I don't want to be stuck
maintaining stuff. And I recognize that unless one is coding a web page with
an expected lifespan of 30 seconds the cost of maintenance dwarfs the cost of
development.
Jon
next prev parent reply other threads:[~2020-01-13 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 22:25 [TUHS] Tech Sq elevator (Was: screen editors) Doug McIlroy
2020-01-12 22:40 ` Kevin Bowling
2020-01-12 23:40 ` [TUHS] Tech Sq elevator [ really type-checking ] Jon Steinhart
2020-01-12 23:50 ` Larry McVoy
2020-01-13 0:01 ` Jon Steinhart [this message]
2020-01-13 0:22 ` Larry McVoy
2020-01-13 0:31 ` Jon Steinhart
2020-01-13 0:44 ` Theodore Y. Ts'o
2020-01-13 0:35 ` Bakul Shah
2020-01-13 0:44 ` Jon Steinhart
2020-01-13 0:49 ` Warren Toomey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001130001.00D012bC608441@darkstar.fourwinds.com \
--to=jon@fourwinds.com \
--cc=tuhs@tuhs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).