From: random832@fastmail.com (Random832)
Subject: [TUHS] link() syscall implementation
Date: Sat, 14 Nov 2015 18:07:16 -0500 [thread overview]
Message-ID: <m2y4e0p4d7.fsf@fastmail.com> (raw)
In-Reply-To: <20151114224205.Horde.pNedl1JFkdNwTKQKHr6OiXv@avocado.salatschuessel.net>
Oliver Lehmann <lehmann at ans-netz.de> writes:
> OK - it is not temporarily copied to rr4, but directly modfied in
> rr2 and then assigned to u.u_dirp. It should be "the same" - But
> - ln(1) does not work with this code. Instead of creating a
> hardlink, it creates a new empty file (different inode).
Are you sure this is where the problem is?
For the pointer assignment, what about just using u.u_dirp.l =
uap->linkname, and validating there are no invalid bits (return EFAULT
or raise SIGSEGV if so - also should the user code really be allowed to
pass in arbitrary segment IDs?) in a separate step?
next prev parent reply other threads:[~2015-11-14 23:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 12:34 Oliver Lehmann
2015-11-14 12:56 ` Oliver Lehmann
2015-11-14 15:17 ` Oliver Lehmann
2015-11-14 21:18 ` Random832
2015-11-14 21:42 ` Oliver Lehmann
2015-11-14 23:07 ` Random832 [this message]
2015-11-15 14:43 ` Oliver Lehmann
2015-11-14 13:33 ` Random832
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y4e0p4d7.fsf@fastmail.com \
--to=random832@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).