[PR PATCH] build-style/go: make do_install() really fail on errors.

[PR PATCH] build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

There is a new pull request by xtraeme against master on the void-packages repository

https://github.com/xtraeme/void-packages build-style-go
https://github.com/void-linux/void-packages/pull/12442

build-style/go: make do_install() really fail on errors.
This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.

Still affected packages must be fixed, doctl being one of them.

A patch file from https://github.com/void-linux/void-packages/pull/12442.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style-go-12442.patch --]
[-- Type: application/text/x-diff, Size: 883 bytes --]

From 1901f1aaf0685726be6cdefcb837ce2f198034a9 Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 17:51:39 +0200
Subject: [PATCH] build-style/go: make do_install() really fail on errors.

This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.

Still affected packages must be fixed, doctl being one of them.
---
 common/build-style/go.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 98f95bea2e5..f6b772c7704 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,8 +41,7 @@ do_build() {
 }
 
 do_install() {
-	find "${GOPATH}/bin" -type f -executable | while read line
-	do
-		vbin "${line}"
+	for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+		vbin "$f"
 	done
 }

Re: build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/12442#issuecomment-501763679
Comment:
This is for #12441 

Re: [PR PATCH] [Updated] build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

There is an updated pull request by xtraeme against master on the void-packages repository

https://github.com/xtraeme/void-packages build-style-go
https://github.com/void-linux/void-packages/pull/12442

build-style/go: make do_install() really fail on errors.
This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.

Still affected packages must be fixed, doctl being one of them.

A patch file from https://github.com/void-linux/void-packages/pull/12442.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style-go-12442.patch --]
[-- Type: application/text/x-diff, Size: 1592 bytes --]

From 1901f1aaf0685726be6cdefcb837ce2f198034a9 Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 17:51:39 +0200
Subject: [PATCH 1/2] build-style/go: make do_install() really fail on errors.

This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.

Still affected packages must be fixed, doctl being one of them.
---
 common/build-style/go.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 98f95bea2e5..f6b772c7704 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,8 +41,7 @@ do_build() {
 }
 
 do_install() {
-	find "${GOPATH}/bin" -type f -executable | while read line
-	do
-		vbin "${line}"
+	for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+		vbin "$f"
 	done
 }

From e3c550e9b6e3cf1d878fedf649dd7fdfd7879e2e Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 19:52:03 +0200
Subject: [PATCH 2/2] build-style/go: fix quoting, found by @huglovefan.

Signed-off-by: Juan RP <xtraeme@gmail.com>
---
 common/build-style/go.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index f6b772c7704..5552792169d 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,7 +41,7 @@ do_build() {
 }
 
 do_install() {
-	for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+	for f in $(find "${GOPATH}/bin" -type f -executable); do
 		vbin "$f"
 	done
 }

Re: [PR PATCH] [Updated] build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

There is an updated pull request by xtraeme against master on the void-packages repository

https://github.com/xtraeme/void-packages build-style-go
https://github.com/void-linux/void-packages/pull/12442

build-style/go: make do_install() really fail on errors.
This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.

Still affected packages must be fixed, doctl being one of them.

A patch file from https://github.com/void-linux/void-packages/pull/12442.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style-go-12442.patch --]
[-- Type: application/text/x-diff, Size: 1592 bytes --]

From 1901f1aaf0685726be6cdefcb837ce2f198034a9 Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 17:51:39 +0200
Subject: [PATCH 1/2] build-style/go: make do_install() really fail on errors.

This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.

Still affected packages must be fixed, doctl being one of them.
---
 common/build-style/go.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 98f95bea2e5..f6b772c7704 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,8 +41,7 @@ do_build() {
 }
 
 do_install() {
-	find "${GOPATH}/bin" -type f -executable | while read line
-	do
-		vbin "${line}"
+	for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+		vbin "$f"
 	done
 }

From e3c550e9b6e3cf1d878fedf649dd7fdfd7879e2e Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 19:52:03 +0200
Subject: [PATCH 2/2] build-style/go: fix quoting, found by @huglovefan.

Signed-off-by: Juan RP <xtraeme@gmail.com>
---
 common/build-style/go.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index f6b772c7704..5552792169d 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,7 +41,7 @@ do_build() {
 }
 
 do_install() {
-	for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+	for f in $(find "${GOPATH}/bin" -type f -executable); do
 		vbin "$f"
 	done
 }

Re: build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/12442#issuecomment-501951382
Comment:
If GOPATH is empty, as in the case of packages that build exclusively with modules, this will try to generate a package containing all of /bin.

Re: build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/12442#issuecomment-502002031
Comment:
I see, the real problem probably is empty GOPATH.

Re: build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/12442#issuecomment-551392289

Comment:
If there were a version of this that didn't try to install all of /bin that would be really nice.  @zdtcd do you want to try and tackle that in a new PR?

Re: build-style/go: make do_install() really fail on errors.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by zdtcd on void-packages repository

https://github.com/void-linux/void-packages/pull/12442#issuecomment-551394124

Comment:
On November 8, 2019 5:38:13 AM UTC, Michael Aldridge <notifications@github.com> wrote:
>If there were a version of this that didn't try to install all of /bin
>that would be really nice.  @zdtcd do you want to try and tackle that
>in a new PR?

I'm busy with something in git.git

If noone take over this one, I'll try after settling that series.
-- 
Danh