From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] build-style/go: make do_install() really fail on errors.
Date: Thu, 13 Jun 2019 19:52:38 +0200 [thread overview]
Message-ID: <20190613175238.budEWN-gv1NdV6a8GXm5NLShP2rUove7z57BqARWMv8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-12442@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
There is an updated pull request by xtraeme against master on the void-packages repository
https://github.com/xtraeme/void-packages build-style-go
https://github.com/void-linux/void-packages/pull/12442
build-style/go: make do_install() really fail on errors.
This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.
Still affected packages must be fixed, doctl being one of them.
A patch file from https://github.com/void-linux/void-packages/pull/12442.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style-go-12442.patch --]
[-- Type: application/text/x-diff, Size: 1592 bytes --]
From 1901f1aaf0685726be6cdefcb837ce2f198034a9 Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 17:51:39 +0200
Subject: [PATCH 1/2] build-style/go: make do_install() really fail on errors.
This fixes detection of some go packages (doctl) that are
simply empty because it couldn't find the binaries in $GOPATH/bin.
Still affected packages must be fixed, doctl being one of them.
---
common/build-style/go.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 98f95bea2e5..f6b772c7704 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,8 +41,7 @@ do_build() {
}
do_install() {
- find "${GOPATH}/bin" -type f -executable | while read line
- do
- vbin "${line}"
+ for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+ vbin "$f"
done
}
From e3c550e9b6e3cf1d878fedf649dd7fdfd7879e2e Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Thu, 13 Jun 2019 19:52:03 +0200
Subject: [PATCH 2/2] build-style/go: fix quoting, found by @huglovefan.
Signed-off-by: Juan RP <xtraeme@gmail.com>
---
common/build-style/go.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index f6b772c7704..5552792169d 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -41,7 +41,7 @@ do_build() {
}
do_install() {
- for f in "$(find "${GOPATH}/bin" -type f -executable)"; do
+ for f in $(find "${GOPATH}/bin" -type f -executable); do
vbin "$f"
done
}
next prev parent reply other threads:[~2019-06-13 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 15:54 [PR PATCH] " voidlinux-github
2019-06-13 15:54 ` voidlinux-github
2019-06-13 17:52 ` voidlinux-github [this message]
2019-06-13 17:52 ` [PR PATCH] [Updated] " voidlinux-github
2019-06-14 3:09 ` voidlinux-github
2019-06-14 7:31 ` voidlinux-github
2019-11-08 5:38 ` voidlinux-github
2019-11-08 5:47 ` voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613175238.budEWN-gv1NdV6a8GXm5NLShP2rUove7z57BqARWMv8@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).