[PR PATCH] xbps-src: redirect various error msg to stderr

[PR PATCH] xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

There is a new pull request by zdtcd against master on the void-packages repository

https://github.com/zdtcd/void-packages xbps-src
https://github.com/void-linux/void-packages/pull/12962

xbps-src: redirect various error msg to stderr
ref: https://github.com/void-linux/void-packages/issues/12907

A patch file from https://github.com/void-linux/void-packages/pull/12962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-src-12962.patch --]
[-- Type: application/text/x-diff, Size: 2218 bytes --]

From 4956e7fb585079270eb202ae9553a4e7eec1d8ea Mon Sep 17 00:00:00 2001
From: Doan Tran Cong Danh <congdanhqx@gmail.com>
Date: Wed, 10 Jul 2019 15:31:21 +0700
Subject: [PATCH] xbps-src: redirect various error msg to stderr

---
 xbps-src | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xbps-src b/xbps-src
index 23d6164b18a..9fbdf4aec01 100755
--- a/xbps-src
+++ b/xbps-src
@@ -214,7 +214,7 @@ check_reqhost_utils() {
 
     for f in ${REQHOST_UTILS}; do
         if ! command -v ${f} &>/dev/null; then
-            echo "${f} is missing in your system, can't continue!"
+            echo "${f} is missing in your system, can't continue!" 1>&2
             broken=1
         fi
     done
@@ -223,7 +223,7 @@ check_reqhost_utils() {
 
     for f in ${REQHOST_UTILS_BOOTSTRAP}; do
         if ! command -v ${f} &>/dev/null; then
-            echo "${f} is missing in your system, can't continue!"
+            echo "${f} is missing in your system, can't continue!" 1>&2
             broken=1
         fi
     done
@@ -242,7 +242,7 @@ check_config_vars() {
         [ ! -d $XBPS_HOSTDIR ] && mkdir -p $XBPS_HOSTDIR
     fi
     if [ -d "$XBPS_MASTERDIR" -a ! -w "$XBPS_MASTERDIR" ]; then
-        echo "ERROR: not enough perms for masterdir $XBPS_MASTERDIR."
+        echo "ERROR: not enough perms for masterdir $XBPS_MASTERDIR." 1>&2
         exit 1
     fi
 }
@@ -257,8 +257,8 @@ check_build_requirements() {
     if [ -z "$found" ]; then
         xbps-uhelper cmpver "$XBPS_VERSION" "$XBPS_VERSION_REQ"
         if [ $? -eq 255 ]; then
-            echo "ERROR: requires xbps>=${XBPS_VERSION_REQ}"
-            echo "Bootstrap packages must be updated with 'xbps-src bootstrap-update'"
+            echo "ERROR: requires xbps>=${XBPS_VERSION_REQ}" 1>&2
+            echo "Bootstrap packages must be updated with 'xbps-src bootstrap-update'" 1>&2
             exit 1
         fi
     fi
@@ -462,7 +462,7 @@ if command -v chroot-git &>/dev/null; then
 elif command -v git &>/dev/null; then
 	XBPS_GIT_CMD=$(command -v git)
 else
-    echo "neither chroot-git or git are available in your system!"
+    echo "neither chroot-git or git are available in your system!" 1>&2
     exit 1
 fi
 

Re: xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/12962#issuecomment-512684223
Comment:
:+1: please rebase

I'm thinking about replacing these calls with `msg_error`, but I'm not perfectly sure if everything is initialized properly.

Re: xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

New comment by zdtcd on void-packages repository

https://github.com/void-linux/void-packages/pull/12962#issuecomment-512693929
Comment:
Lemme trace those code to check if we can replace them with msg_error or not.

On July 18, 2019 6:33:19 AM UTC, Enno Boland <notifications@github.com> wrote:
>:+1: please rebase
>
>I'm thinking about replacing these calls with `msg_error`, but I'm not
>perfectly sure if everything is initialized properly.
>
>-- 
>You are receiving this because you authored the thread.
>Reply to this email directly or view it on GitHub:
>https://github.com/void-linux/void-packages/pull/12962#issuecomment-512684223

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [PR PATCH] [Updated] xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

There is an updated pull request by zdtcd against master on the void-packages repository

https://github.com/zdtcd/void-packages xbps-src
https://github.com/void-linux/void-packages/pull/12962

xbps-src: redirect various error msg to stderr
ref: https://github.com/void-linux/void-packages/issues/12907

A patch file from https://github.com/void-linux/void-packages/pull/12962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-src-12962.patch --]
[-- Type: application/text/x-diff, Size: 2260 bytes --]

From 37d4b043479eb74bdbd8e32691197c40b10f2a60 Mon Sep 17 00:00:00 2001
From: Doan Tran Cong Danh <congdanhqx@gmail.com>
Date: Wed, 10 Jul 2019 15:31:21 +0700
Subject: [PATCH] xbps-src: redirect various error msg to stderr

We couldn't use msg_red or msg_error,
since they won't be available until line #680
---
 xbps-src | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xbps-src b/xbps-src
index 8e07058893e..cf2821586a0 100755
--- a/xbps-src
+++ b/xbps-src
@@ -212,7 +212,7 @@ check_reqhost_utils() {
 
     for f in ${REQHOST_UTILS}; do
         if ! command -v ${f} &>/dev/null; then
-            echo "${f} is missing in your system, can't continue!"
+            echo "${f} is missing in your system, can't continue!" 1>&2
             broken=1
         fi
     done
@@ -221,7 +221,7 @@ check_reqhost_utils() {
 
     for f in ${REQHOST_UTILS_BOOTSTRAP}; do
         if ! command -v ${f} &>/dev/null; then
-            echo "${f} is missing in your system, can't continue!"
+            echo "${f} is missing in your system, can't continue!" 1>&2
             broken=1
         fi
     done
@@ -238,8 +238,8 @@ check_build_requirements() {
     if [ -z "$found" ]; then
         xbps-uhelper cmpver "$XBPS_VERSION" "$XBPS_VERSION_REQ"
         if [ $? -eq 255 ]; then
-            echo "ERROR: requires xbps>=${XBPS_VERSION_REQ}"
-            echo "Bootstrap packages must be updated with 'xbps-src bootstrap-update'"
+            echo "ERROR: requires xbps>=${XBPS_VERSION_REQ}" 1>&2
+            echo "Bootstrap packages must be updated with 'xbps-src bootstrap-update'" 1>&2
             exit 1
         fi
     fi
@@ -501,7 +501,7 @@ fi
 [ ! -d $XBPS_HOSTDIR ] && mkdir -p $XBPS_HOSTDIR
 
 if [ -d "$XBPS_MASTERDIR" -a ! -w "$XBPS_MASTERDIR" ]; then
-    echo "ERROR: can't write to masterdir $XBPS_MASTERDIR."
+    echo "ERROR: can't write to masterdir $XBPS_MASTERDIR." 1>&2
     exit 1
 fi
 
@@ -511,7 +511,7 @@ if command -v chroot-git &>/dev/null; then
 elif command -v git &>/dev/null; then
     XBPS_GIT_CMD=$(command -v git)
 else
-    echo "neither chroot-git or git are available in your system!"
+    echo "neither chroot-git or git are available in your system!" 1>&2
     exit 1
 fi
 readonly XBPS_GIT_CMD

Re: [PR PATCH] [Updated] xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

There is an updated pull request by zdtcd against master on the void-packages repository

https://github.com/zdtcd/void-packages xbps-src
https://github.com/void-linux/void-packages/pull/12962

xbps-src: redirect various error msg to stderr
ref: https://github.com/void-linux/void-packages/issues/12907

A patch file from https://github.com/void-linux/void-packages/pull/12962.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-src-12962.patch --]
[-- Type: application/text/x-diff, Size: 2260 bytes --]

From 37d4b043479eb74bdbd8e32691197c40b10f2a60 Mon Sep 17 00:00:00 2001
From: Doan Tran Cong Danh <congdanhqx@gmail.com>
Date: Wed, 10 Jul 2019 15:31:21 +0700
Subject: [PATCH] xbps-src: redirect various error msg to stderr

We couldn't use msg_red or msg_error,
since they won't be available until line #680
---
 xbps-src | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xbps-src b/xbps-src
index 8e07058893e..cf2821586a0 100755
--- a/xbps-src
+++ b/xbps-src
@@ -212,7 +212,7 @@ check_reqhost_utils() {
 
     for f in ${REQHOST_UTILS}; do
         if ! command -v ${f} &>/dev/null; then
-            echo "${f} is missing in your system, can't continue!"
+            echo "${f} is missing in your system, can't continue!" 1>&2
             broken=1
         fi
     done
@@ -221,7 +221,7 @@ check_reqhost_utils() {
 
     for f in ${REQHOST_UTILS_BOOTSTRAP}; do
         if ! command -v ${f} &>/dev/null; then
-            echo "${f} is missing in your system, can't continue!"
+            echo "${f} is missing in your system, can't continue!" 1>&2
             broken=1
         fi
     done
@@ -238,8 +238,8 @@ check_build_requirements() {
     if [ -z "$found" ]; then
         xbps-uhelper cmpver "$XBPS_VERSION" "$XBPS_VERSION_REQ"
         if [ $? -eq 255 ]; then
-            echo "ERROR: requires xbps>=${XBPS_VERSION_REQ}"
-            echo "Bootstrap packages must be updated with 'xbps-src bootstrap-update'"
+            echo "ERROR: requires xbps>=${XBPS_VERSION_REQ}" 1>&2
+            echo "Bootstrap packages must be updated with 'xbps-src bootstrap-update'" 1>&2
             exit 1
         fi
     fi
@@ -501,7 +501,7 @@ fi
 [ ! -d $XBPS_HOSTDIR ] && mkdir -p $XBPS_HOSTDIR
 
 if [ -d "$XBPS_MASTERDIR" -a ! -w "$XBPS_MASTERDIR" ]; then
-    echo "ERROR: can't write to masterdir $XBPS_MASTERDIR."
+    echo "ERROR: can't write to masterdir $XBPS_MASTERDIR." 1>&2
     exit 1
 fi
 
@@ -511,7 +511,7 @@ if command -v chroot-git &>/dev/null; then
 elif command -v git &>/dev/null; then
     XBPS_GIT_CMD=$(command -v git)
 else
-    echo "neither chroot-git or git are available in your system!"
+    echo "neither chroot-git or git are available in your system!" 1>&2
     exit 1
 fi
 readonly XBPS_GIT_CMD

Re: xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by zdtcd on void-packages repository

https://github.com/void-linux/void-packages/pull/12962#issuecomment-513182881
Comment:
We can't use msg_error. They won't be available until line #680

Re: xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/12962#issuecomment-514626560
Comment:
Ok, leave it as it is.

Re: [PR PATCH] [Merged]: xbps-src: redirect various error msg to stderr

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

There's a merged pull request on the void-packages repository

xbps-src: redirect various error msg to stderr
https://github.com/void-linux/void-packages/pull/12962
Description: ref: https://github.com/void-linux/void-packages/issues/12907